Update CEC Inverters for Fall 2023#1607
Merged
Merged
Conversation
Revise readme
* Update CEC inverter library with data from 11/17/2023 CEC workbook * Replace default inverter for PV configs -- previous default inverter no longer in library, Fixes #1595 * Update inverter library generation files in SAM/Samples * Update defaults for new default inverters
mjprilliman
reviewed
Nov 29, 2023
| // SAM 2022.11.21 default inverters are not in new CEC inverters library | ||
| if ( cfg.tech == 'Flat Plate PV' || cfg.tech == 'PV Battery' || cfg.tech == 'High-X Concentrating PV' ) | ||
| { | ||
| old_inverter = value( 'inv_snl_inverter_name' ); |
Collaborator
There was a problem hiding this comment.
When I run the upgrade script old_inverter returns as null:
Then this notice pops up after choosing a new inverter from the list:
Maybe that's normal but wanted to note.
mjprilliman
approved these changes
Nov 29, 2023
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
Upgrade worked after updates. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CEC inverter library
Fixes #1595
Note Merge this after merging module update.