Update NSRDB in UI callback to PSM V3.2.2#1559
Merged
Merged
Conversation
Collaborator
All 167 default configurations running on Windows
sjanzou
approved these changes
Nov 10, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Solar resource page changes look good.
Defaults updated to include new variable t_wet.
All 167 defaults running on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Update UI callback script on Solar Resource Data form to download data from NSRDB PSM V3.2.2 and PSM V3.2.2-tmy endpoints.
Requires building SAM-private to test NSRDB downloads, or setting keys in private.h.
To test, create a solar case, and choose the "Choose year" option on the Solar Resource page. List should show files for years up to 2022.
Fixes #1557
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.