Add technology condition to critical load error message#1412
Merged
Conversation
- only check critical load time step if tech has grid outage inputs (is a battery storage tech)
brtietz
approved these changes
Jun 2, 2023
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Works well, thanks for fixing!
sjanzou
approved these changes
Jun 3, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Works with PV residential with and without storage with no callback error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only check critical load time step if tech has grid outage inputs (is a battery storage tech).
Fixes #1411
Type of change
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.