Skip to content

Fix UI checks for load and crit_load#1397

Merged
cpaulgilman merged 2 commits into
patchfrom
load_ui_checks
May 5, 2023
Merged

Fix UI checks for load and crit_load#1397
cpaulgilman merged 2 commits into
patchfrom
load_ui_checks

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Description

Goes with NatLabRockies/ssc#1021

Fixes NatLabRockies/ssc#1015

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Check handled in UI callback and SSC.
- Unrelated to load UI checks, but quick fix for debug error scanning solar resource library.

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpaulgilman cpaulgilman merged commit 7156701 into patch May 5, 2023
@cpaulgilman cpaulgilman deleted the load_ui_checks branch May 5, 2023 22:30
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check that load and critical load data have same time step

2 participants