Skip to content

Fix equation call to geothermal costs calculations#1379

Merged
mjprilliman merged 1 commit into
patchfrom
geothermal-plant-capex-eqn
Mar 23, 2023
Merged

Fix equation call to geothermal costs calculations#1379
mjprilliman merged 1 commit into
patchfrom
geothermal-plant-capex-eqn

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

Fix call to geothermal cost module when 'Automatically estimate the plant cost per kW' is checked

Fixes #1378

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I wrote an LK script to automatically copy the .json file to the runtime/ui folder as a workaround until the next SAM update. To use it:

  1. Download fix-geothermal-ui.zip and extract the .lk and .json files into a single folder such as the Desktop folder.
  2. Start SAM, and click Open script on the Welcome page. (Do not start or open a project.)
  3. Click Run at the top of the script editor window.

@mjprilliman mjprilliman merged commit a39ace0 into patch Mar 23, 2023
@mjprilliman mjprilliman deleted the geothermal-plant-capex-eqn branch March 23, 2023 16:10
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug geothermal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geothermal plant capital cost equation error

2 participants