Skip to content

Fix loss factor adjustment widget descriptive text#1355

Merged
mjprilliman merged 3 commits into
patchfrom
sam-1277-fix
Feb 17, 2023
Merged

Fix loss factor adjustment widget descriptive text#1355
mjprilliman merged 3 commits into
patchfrom
sam-1277-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Loss factor widgets did not have appropriate descriptive text at the top dialog describing what the widget was used for
-Text is normally edited through the 'Description' property, but this linkage was not working
-Behavior fixed in this PR, appropriate language for each widget provided by Paul
-To test: open loss factor adjustments widget on PV Losses page (or other technology pages), check that text at top of pop-up dialog is appropriate for the model (make sure it isn't blank as well).

Fixes #1277

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the 2022.11.21 Patch 1 milestone Feb 17, 2023
@mjprilliman mjprilliman self-assigned this Feb 17, 2023
@mjprilliman mjprilliman changed the title Sam 1277 fix Fix loss factor adjustment widget descriptive text Feb 17, 2023

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works as advertised, however, if one goes one level deeper, the label is missing:

image

Given the time crunch, I'm happy to have solving that 2nd level widget be a separate issue.

@mjprilliman mjprilliman merged commit bf7a214 into patch Feb 17, 2023
@mjprilliman mjprilliman deleted the sam-1277-fix branch February 17, 2023 23:57
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit Losses widget descriptive text

3 participants