Skip to content

Add Artic XCPC collector to SWH library#1337

Merged
sjanzou merged 1 commit into
patchfrom
swh-artic-collector
Jan 28, 2023
Merged

Add Artic XCPC collector to SWH library#1337
sjanzou merged 1 commit into
patchfrom
swh-artic-collector

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Add Artic Solar collector to SWH library. See Slide 4 of presentation for collector parameters: 10-20-2022_NREL XCPC modeling for SAM.pdf

Fixes #1316

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 1 milestone Jan 28, 2023
@cpaulgilman cpaulgilman requested a review from sjanzou January 28, 2023 03:49
@cpaulgilman cpaulgilman self-assigned this Jan 28, 2023

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well
image

with results for Commercial market
image

@sjanzou sjanzou merged commit 84df7ba into patch Jan 28, 2023
@sjanzou sjanzou deleted the swh-artic-collector branch January 28, 2023 08:23
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Artic collector to SWH library

2 participants