Fix trough loop indicators#1329
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The indicators on the "Collectors (SCAs)" and "Receivers (HCEs)" pages for the trough models:
Collector types in loop configuration: Cold - 1 - 1 - 1 - 1 - 1 - 1 - 1 - 1 - Hot
Receiver types in loop configuration: Cold - 1 - 1 - 1 - 1 - 1 - 1 - 1 - 1 - Hot
do not reflect the configuration of the Single Loop Configuration widget on the Solar Field page. The collector configurations appears to show in the receiver indicator and vice-versa.
Explanation:
The problem arises because the UI reuses Sca_info_array() when displaying the SCA and HCE indicators on the respective UI pages, respectively. Since Sca_info_array() flips the convention for the sake of the SSC submodel, the indicator should not have the same convention as the UI widget, it should be flipped. And this is what was likely the confusion when this was implemented.
Solution:
Flip the convention in the '$MIMO$ collectors in field' and 'receivers_in_field' Equations on the "Physical Trough Collector Header" and "Physical Trough Receiver Header" UI Forms.
Closes #1319