Skip to content

Fix callbacks for loss adjustments#1309

Merged
mjprilliman merged 2 commits into
patchfrom
sam-1305-fix
Jan 10, 2023
Merged

Fix callbacks for loss adjustments#1309
mjprilliman merged 2 commits into
patchfrom
sam-1305-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Remove is_assigned check from callbacks for system_use_lifetime_output check in loss adjustment widget
-Replaced to check for LCOE or None financial

Fixes #1305

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the 2022.11.21 Patch 1 milestone Dec 29, 2022
@mjprilliman mjprilliman self-assigned this Dec 29, 2022
@mjprilliman mjprilliman merged commit 5f9a8f9 into patch Jan 10, 2023
@mjprilliman mjprilliman deleted the sam-1305-fix branch January 10, 2023 20:28
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PVWatts Advanced Inputs callback error

2 participants