Skip to content

Invoke cpp changes that go with ssc branch#1301

Merged
brtietz merged 1 commit into
patchfrom
sam_1290_fix_reopt_api_call_pvwatts
Dec 15, 2022
Merged

Invoke cpp changes that go with ssc branch#1301
brtietz merged 1 commit into
patchfrom
sam_1290_fix_reopt_api_call_pvwatts

Conversation

@brtietz

@brtietz brtietz commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

invoke.cpp changes required for NatLabRockies/ssc#952

Fixes #1290

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz added this to the 2022.11.21 Patch 1 milestone Dec 9, 2022
@brtietz brtietz requested a review from cpaulgilman December 9, 2022 23:56

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@brtietz brtietz merged commit 4328de1 into patch Dec 15, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2023
@brtietz brtietz deleted the sam_1290_fix_reopt_api_call_pvwatts branch December 13, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REopt API call fails for PVWatts cases

2 participants