Help revisions for SAM 2022.11.21#1278
Merged
Merged
Conversation
PVWatts Battery section should be in collapsible panel. PVWatts module area estimate is wrong (does not include GCR). Spatial results Remove CSP boiler pressure: MSLF Power Cycle, CSP Rankine Power Cycle: #1192 Edit Losses new minute to add period: #1164 Geothermal resource, fix references, and four options for reservoir parameters. Grid Limits: Battery dispatch does not consider interconnection limit. Detailed PV losses nameplate loss can be up to -5%. PVWatts albedo and advanced inputs. Generic calculate generation profiles... Battery manual dispatch BTM system priority option. Marine wave include Alaska resource, and new "User values from wave resource file" option. Revise annual energy and add cash flow energy items. Revise capacity factor and system capacity table for PV DC and AC capacity Update pv land area for #1127 Bifacial and spatial albedo. GETEM revisions Module efficiency per NatLabRockies/ssc#228 PVWatts versions in PVWatts top-level description: #1159 PDF / CDF tab P-value PV uncertainty Custom HTF optional properties Capacity payments units. Solar water heating change IAM coefficient label and remove total system flow rate. Add link to PV smoothing preprint. PV terrain slope clarification not available for non 1-axis tracking options. NPV tips for interpreting NPV with links from other financial metrics. LCOE calculator note about modeling incentives. Battery results: Battery lifetime AC/DC units Operating costs: Fix AC/DC units, revise escalation. PV losses: Explain percentages for transformer losses, and list output variable names. Grid outage explain battery SOC may go up to 100%: https://sam.nrel.gov/forum/forum-general/3977-battery-soc-when-constrained.html Remove inputs browser link to parametrics youtube video. Merchant plant: Note that revenue is zero if cleared capacity is zero for all time steps. Revenue: Add link to CPUC procurement website for TOD factor library references Replace "REopt Lite" with "REopt" per #1090 Inverter, Weighted Efficiency, update link to European weighted efficiency paper. Generic CSP solar field area estimate in UI different from simulation value: https://sam.nrel.gov/forum/forum-general/3947 PV system design typo in tilt description suggestion to use parametrics: #1084 Fix dead link in Module NOCT temp model description to https://www.energy.ca.gov/programs-and-topics/programs/new-solar-homes-partnership-program-nshp Self shading diffuse irradiance available for thin film and standard self-shading options since SAM 2020.2.29: https://sam.nrel.gov/forum/forum-general/3087
Collaborator
|
I spotted this on a help review, not sure if it belongs in this PR or somewhere else. Should the copyright year(s) on the about: get updated to match the license? https://github.com/NREL/SAM/blob/develop/LICENSE |
sjanzou
approved these changes
Nov 18, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
I agree about the license to be linked somewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PVWatts Battery section should be in collapsible panel.
PVWatts module area estimate is wrong (does not include GCR).
Spatial results
Remove CSP boiler pressure: MSLF Power Cycle, CSP Rankine Power Cycle: #1192
Edit Losses new minute to add period: #1164
Geothermal resource, fix references, and four options for reservoir parameters.
Grid Limits: Battery dispatch does not consider interconnection limit.
Detailed PV losses nameplate loss can be up to -5%.
PVWatts albedo and advanced inputs.
Generic calculate generation profiles...
Battery manual dispatch BTM system priority option.
Marine wave include Alaska resource, and new "User values from wave resource file" option.
Revise annual energy and add cash flow energy items.
Revise capacity factor and system capacity table for PV DC and AC capacity
Update pv land area for #1127
Bifacial and spatial albedo.
GETEM revisions
Module efficiency per NatLabRockies/ssc#228
PVWatts versions in PVWatts top-level description: #1159
PDF / CDF tab P-value
PV uncertainty
Custom HTF optional properties
Capacity payments units.
Solar water heating change IAM coefficient label and remove total system flow rate.
Add link to PV smoothing preprint.
PV terrain slope clarification not available for non 1-axis tracking options.
NPV tips for interpreting NPV with links from other financial metrics.
LCOE calculator note about modeling incentives.
Battery results: Battery lifetime AC/DC units
Operating costs: Fix AC/DC units, revise escalation.
PV losses: Explain percentages for transformer losses, and list output variable names.
Grid outage explain battery SOC may go up to 100%: https://sam.nrel.gov/forum/forum-general/3977-battery-soc-when-constrained.html
Remove inputs browser link to parametrics youtube video.
Merchant plant: Note that revenue is zero if cleared capacity is zero for all time steps.
Revenue: Add link to CPUC procurement website for TOD factor library references
Replace "REopt Lite" with "REopt" per #1090
Inverter, Weighted Efficiency, update link to European weighted efficiency paper.
Generic CSP solar field area estimate in UI different from simulation value: https://sam.nrel.gov/forum/forum-general/3947
PV system design typo in tilt description suggestion to use parametrics: #1084
Fix dead link in Module NOCT temp model description to https://www.energy.ca.gov/programs-and-topics/programs/new-solar-homes-partnership-program-nshp
Self shading diffuse irradiance available for thin film and standard self-shading options since SAM 2020.2.29: https://sam.nrel.gov/forum/forum-general/3087