Skip to content

UI fixes#1202

Merged
cpaulgilman merged 3 commits into
developfrom
ui-fixes
Oct 20, 2022
Merged

UI fixes#1202
cpaulgilman merged 3 commits into
developfrom
ui-fixes

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

These are user interface changes that should not affect test results. Includes changes to:

  • Multiple UI forms to fix typos in variable labels, callback scripts, etc.
  • Macro LK scripts
  • Wind turbine and SRCC collectors library CSV files
  • Marine wave resource file
  • Tooltips file

Fixes #1153
Fixes #1138
Fixes #1118

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

remove spaces before commas

change all "kw" to "kW"

change all "mW" to "MW"
Typos in Help fixed in source files and will be part of a separate commit.
@cpaulgilman cpaulgilman added this to the SAM Fall 2022 Release milestone Oct 20, 2022
@cpaulgilman cpaulgilman self-assigned this Oct 20, 2022

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through this!

@cpaulgilman cpaulgilman merged commit 6784bdf into develop Oct 20, 2022
@cpaulgilman cpaulgilman deleted the ui-fixes branch October 20, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solar Water Heating (SWH) IAM input label misleading Wind turbines in library with spaces at end of name Fix Typos in UI and Help Files

2 participants