Skip to content

Change cambium API URL#1063

Merged
sjanzou merged 2 commits into
patchfrom
cambium_fix
Jun 4, 2022
Merged

Change cambium API URL#1063
sjanzou merged 2 commits into
patchfrom
cambium_fix

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

It looks like we were getting a JSON decoding error trying to decode the POST form, but the issue actually seems to be related to the website URL. We recently switched to use https://scenarioviewer.nrel.gov/ as the site URL and set the old URL to redirect to the new one. It’s likely that the POST form data is being lost during the redirection, but updating the domain in your script to ‘https://scenarioviewer.nrel.gov/’ seems to resolve the issue and get me a 200 response.

Also fixed in SAM-private: https://github.com/NREL/SAM-private/pull/67

Fixes #991

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman self-assigned this Jun 2, 2022
@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Jun 2, 2022
@cpaulgilman cpaulgilman requested a review from sjanzou June 2, 2022 21:37

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with different analysis period and price only data - working well!
Also, the change appears to have already been merged into SAM-private - thanks!

@sjanzou sjanzou merged commit 9557460 into patch Jun 4, 2022
@sjanzou sjanzou deleted the cambium_fix branch June 4, 2022 05:42
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cambium price downloads not working

2 participants