Change cambium API URL#1063
Merged
Merged
Conversation
sjanzou
approved these changes
Jun 3, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Tested with different analysis period and price only data - working well!
Also, the change appears to have already been merged into SAM-private - thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
It looks like we were getting a JSON decoding error trying to decode the POST form, but the issue actually seems to be related to the website URL. We recently switched to use https://scenarioviewer.nrel.gov/ as the site URL and set the old URL to redirect to the new one. It’s likely that the POST form data is being lost during the redirection, but updating the domain in your script to ‘https://scenarioviewer.nrel.gov/’ seems to resolve the issue and get me a 200 response.
Also fixed in SAM-private: https://github.com/NREL/SAM-private/pull/67
Fixes #991
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.