Skip to content

Fix PVsyst PAN to SAM macro for module technology#1047

Merged
cpaulgilman merged 4 commits into
patchfrom
pan_module_params
May 20, 2022
Merged

Fix PVsyst PAN to SAM macro for module technology#1047
cpaulgilman merged 4 commits into
patchfrom
pan_module_params

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

See description in #1029.

To test:

  1. Download and unzip PAN files for testing: pvsyst-pan-technol-tests.zip
  2. Create a new Detailed PV case with any technology.
  3. Click Macros and PVsyst OND - PAN to SAM.
  4. Click Run macro.
  5. Import each of the test PAN files and verify that Cell type on the Module page is consistent with the Technol parameter in the PAN file. Invalid or types that SAM does not recognize should convert to monoSi.

Fixes #1029

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone May 19, 2022
@cpaulgilman cpaulgilman requested a review from mjprilliman May 19, 2022 16:10
@cpaulgilman cpaulgilman self-assigned this May 19, 2022
@cpaulgilman

cpaulgilman commented May 19, 2022

Copy link
Copy Markdown
Collaborator Author

Updated files for testing:
pvsyst-pan-technol-tests-rev.zip

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Might be worth updating the SAM version that the macro has been tested on?

@cpaulgilman cpaulgilman merged commit 434b43a into patch May 20, 2022
@cpaulgilman cpaulgilman deleted the pan_module_params branch May 20, 2022 23:30
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update list of module types in PVsyst PAN to SAM macro

2 participants