Skip to content

Fix Inverter Temp Derate table callback errors#1027

Merged
mjprilliman merged 2 commits into
patchfrom
SAM-739-fix
May 6, 2022
Merged

Fix Inverter Temp Derate table callback errors#1027
mjprilliman merged 2 commits into
patchfrom
SAM-739-fix

Conversation

@mjprilliman

@mjprilliman mjprilliman commented May 3, 2022

Copy link
Copy Markdown
Collaborator

Description

-Added msgbox warning when incorrect inputs are used for inverter temp derates table. Applies when there are no corresponding slopes for temperature input in the row (even number of columns), or maximum number of pairs is exceeded (ncols > 9).
-Also showing red text underneath table when incorrect inputs are there to indicate to user that plot is not up to date.
-Closes #739

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added bug pv pvsam1, pvwatts, hcpv labels May 3, 2022
@mjprilliman mjprilliman added this to the 2021.12.02 Patch 2 milestone May 3, 2022
@mjprilliman mjprilliman self-assigned this May 3, 2022
@cpaulgilman

cpaulgilman commented May 4, 2022

Copy link
Copy Markdown
Collaborator

Looks good. Some suggested text revisions --

For the message box text:

msgbox('Inverter Temperature Derate Table Error.\nThe number of columns in the table is incorrect. Each row must have one Vdc value and at least one pair of Tstart-Slope values. Acceptable numbers of columns are 3, 5, 7, and 9 for up to four Tstart-Slope pairs.');

For the label text:

property('inv_derate_label', 'Caption', 'Inputs are incorrect. Please check the number of columns in the table.');

Please also change the other message box text to add 'Inverter Temperature Derate Table Error.\n' for nicer looking formatting, and consider modifying inv_derate_label for those other two error conditions so that a red error message appears with those table entry labels like: 'Inputs are not correct. Start temp '+p+ ' of curve ' + idx+ ' is not valid.'

cpaulgilman
cpaulgilman approved these changes May 6, 2022
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mjprilliman mjprilliman merged commit 1492597 into patch May 6, 2022
@mjprilliman mjprilliman deleted the SAM-739-fix branch May 6, 2022 19:17
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

@janinefreeman janinefreeman Awaiting requested review from janinefreeman

Assignees

@mjprilliman mjprilliman

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug pv pvsam1, pvwatts, hcpv

Projects

None yet

Milestone

2021.12.02 Patch 2

Development

Successfully merging this pull request may close these issues.

Inverter Temperature Derate Curves table causes callback error

2 participants

@mjprilliman @cpaulgilman