Fix 11300 - Crash When Adding Windows to Rotating Building Using Site:VariableLocation#11314
Merged
mitchute merged 4 commits intoNatLabRockies:developfrom Nov 7, 2025
Conversation
mitchute
reviewed
Nov 7, 2025
Comment on lines
-291
to
+307
| ErrorObjectHeader eoh{routineName, ipsc->cCurrentModuleObject, ""}; | ||
|
|
||
| if (ipsc->lAlphaFieldBlanks(1)) { | ||
| } else if ((state.dataEnvrn->varyingLocationLatSched = Sched::GetSchedule(state, ipsc->cAlphaArgs(1))) == nullptr) { | ||
| ShowSevereItemNotFound(state, eoh, ipsc->cAlphaFieldNames(1), ipsc->cAlphaArgs(1)); | ||
| } | ||
| std::string newName = Util::makeUPPER(ipsc->cAlphaArgs(1)); | ||
| ErrorObjectHeader eoh{routineName, ipsc->cCurrentModuleObject, newName}; | ||
|
|
||
| if (ipsc->lAlphaFieldBlanks(2)) { | ||
| } else if ((state.dataEnvrn->varyingLocationLongSched = Sched::GetSchedule(state, ipsc->cAlphaArgs(2))) == nullptr) { | ||
| } else if ((state.dataEnvrn->varyingLocationLatSched = Sched::GetSchedule(state, ipsc->cAlphaArgs(2))) == nullptr) { | ||
| ShowSevereItemNotFound(state, eoh, ipsc->cAlphaFieldNames(2), ipsc->cAlphaArgs(2)); | ||
| } | ||
|
|
||
| if (ipsc->lAlphaFieldBlanks(3)) { | ||
| } else if ((state.dataEnvrn->varyingOrientationSched = Sched::GetSchedule(state, ipsc->cAlphaArgs(3))) == nullptr) { | ||
| } else if ((state.dataEnvrn->varyingLocationLongSched = Sched::GetSchedule(state, ipsc->cAlphaArgs(3))) == nullptr) { | ||
| ShowSevereItemNotFound(state, eoh, ipsc->cAlphaFieldNames(3), ipsc->cAlphaArgs(3)); | ||
| } | ||
|
|
||
| if (ipsc->lAlphaFieldBlanks(4)) { | ||
| } else if ((state.dataEnvrn->varyingOrientationSched = Sched::GetSchedule(state, ipsc->cAlphaArgs(4))) == nullptr) { | ||
| ShowSevereItemNotFound(state, eoh, ipsc->cAlphaFieldNames(4), ipsc->cAlphaArgs(4)); | ||
| } |
Collaborator
There was a problem hiding this comment.
Looks right. Interesting that this was never caught before.
Contributor
|
Thanks @kevin-moos and @mitchute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
Fix crash when using multiple windows with Site:VariableLocation. This was due to NewVertex not being allocated.
Fix defect in which fields are not processed in the correct order for Site:VariableLocation.
Add unit test to check for crashes.
Pull Request Author
Reviewer