Skip to content

Fix space component loads reporting when number of spaces exceeds number of zones#11278

Merged
mitchute merged 1 commit intodevelopfrom
FixSpaceComponentLoadLoops
Oct 23, 2025
Merged

Fix space component loads reporting when number of spaces exceeds number of zones#11278
mitchute merged 1 commit intodevelopfrom
FixSpaceComponentLoadLoops

Conversation

@mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Oct 16, 2025

Pull request overview

  • Fixes bad loop limits for space component loads accumulating and reporting. Previously, space component loads were not reported for any spaces beyond the number of Zones.

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Oct 16, 2025
@mjwitte mjwitte added this to the EnergyPlus 25.2 milestone Oct 16, 2025
@mjwitte
Copy link
Contributor Author

mjwitte commented Oct 16, 2025

Table output TOC for 5ZoneAirCooledWithSpacesHVAC:

Develop:
image

This branch:
image

@github-actions
Copy link

⚠️ Regressions detected on macos-14 for commit 03a5e44

Regression Summary
  • Table Big Diffs: 1

@github-actions
Copy link

⚠️ Regressions detected on ubuntu-24.04 for commit 03a5e44

Regression Summary
  • Table Big Diffs: 1

Copy link
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a good fix. If IRC the number of spaces is the same or larger than number of zones (i.e., all zones have 1 or more spaces) then that would simply mean missing reports. It's not possible for the number of spaces to be less than the number of zones so there would never be a space array access violation.

@rraustad
Copy link
Collaborator

Ah, when all the spaces aren't included there could also be missing information in the tables that are reported.

{CD7305CB-53FA-4E6F-968D-8B16C7D1FC4F}

@rraustad
Copy link
Collaborator

@mitchute let 'er rip.

@dareumnam dareumnam self-requested a review October 23, 2025 07:04
@dareumnam
Copy link
Collaborator

Oh wow, thank you so much for catching and fixing this issue! We had missed the cases where the number of spaces was greater than the number of zones...😱
I successfully built the branch, ran the testfile on both this branch and develop, and confirmed that the table outputs look correct compared to the develop branch, as shown in the comment above. @mitchute This PR is ready to be merged in.

@mitchute mitchute merged commit 0c78c55 into develop Oct 23, 2025
12 checks passed
@mitchute mitchute deleted the FixSpaceComponentLoadLoops branch October 23, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants