Fix #11256 - Mac packaging: sign scipy/numpy dylibs + replace mactex with basictex by jmarrec · Pull Request #11265 · NatLabRockies/EnergyPlus

jmarrec · 2025-10-09T13:07:26Z

Pull request overview

Fixes Mac packaging is broken on last test release #11256

Description of the purpose of this PR

Sign the numpy/scipy dylibs (ghedesigner was added and it pulls these)
Mactex was used for building latex via brew install mactex-nogui. This can take up to 45 minutes, because that is a 4.0 GB package, and the CTAN mirrors are pretty crap sometimes.
- Having a full distro is nice because you definitely aren't missing a single package...
- But similar to Windows, we can figure out ahead of time what we need, and just install the missing ones
- Having done that legwork, the install time takes 2min now!

Here is a workflow where it took 45 minutes:

https://github.com/jmarrec/EnergyPlus/actions/runs/18312690117/job/52144877361#step:7:136

Tue, 07 Oct 2025 12:32:27 GMT ==> Downloading from https://mirror.clarkson.edu/ctan/systems/mac/mactex/mactex-20250308.pkg
Tue, 07 Oct 2025 13:13:25 GMT ==> Installing dependencies: jbig2dec, openjpeg, webp, leptonica, libb2, libarchive, libidn, fribidi, pango, tesseract, ghostscript

Pull Request Author

Reviewer

…el (EOL August 2027) https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

…nutes for the brew install to work), try basictex

.github/workflows/build_documentation.yml

jmarrec · 2025-10-09T13:08:37Z

.github/workflows/build_documentation.yml

+#         - os: macos-15
+#           generator: "Unix Makefiles"
+#           pretty: 'Mac arm64'


I tested with this workflow with macos-15 and macos-15-intel and ended up commenting them out for now. THe full run takes about 6min on macos-15 (arm64) and 8min30 on macos-15-intel.

Just confirming - you'll turn this back on in a separate PR?

It wasn't part of the build matrix, so I didn't turn it on in the end.

I added it so I could test doc builds in a speedier fashion that launching a release, then commented it out.

jmarrec · 2025-10-09T13:09:39Z

.github/workflows/build_documentation.yml

+        # sudo tlmgr list --only-installed --data name > ori_installed.lst
+        # sudo tlmgr install texliveonfly
+        # sudo texliveonfly --compiler=xelatex dependencies.tex
+        # sudo tlmgr list --only-installed --data name > new_installed.lst
+        # python -c "from pathlib import Path; ori_lines = set(Path('./ori_installed.lst').read_text().splitlines()); new_lines = set(Path('./new_installed.lst').read_text().splitlines()); new_pkgs = new_lines - ori_lines; print([x for x in new_pkgs if not x.startswith('texliveonfly')])"


Initially I just did tlmgr update --self and these commands to find out what I needed exactly.

I then replaced with sudo tlmgr install enumitem framed multirow siunitx as it's faster than using texliveonfly

jmarrec · 2025-10-09T13:10:01Z

.github/workflows/build_documentation.yml

+      if: always()
      with:
-        name: "AllDocumentation-${{ github.event.pull_request.head.sha }}"
+        name: "AllDocumentation-${{ matrix.os }}-${{ github.event.pull_request.head.sha }}"


I'm uploading the entire pdf folder for all runners, so we can spot check them

jmarrec · 2025-10-09T13:10:18Z

.github/workflows/release_mac.yml

        include:
        - macos_dev_target: 12.1
-          os: macos-13
+          os: macos-15-intel


macos-13 is going to be removed in December, replae with macos-15-intel (EOL August 2027)

https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

jmarrec · 2025-10-09T13:10:27Z

.github/workflows/release_mac.yml

        aria2c https://www.apple.com/certificateauthority/DeveloperIDG2CA.cer
        security import AppleWWDRCAG2.cer -k $KEYCHAIN_PATH
-        security import DeveloperIDG2CA.cer -k $KEYCHAIN_PATH
+        security import DeveloperIDG2CA.cer -k $KEYCHAIN_PATH || true  # macos-15-intel seems to already have it


That's weird but it's what it is...

jmarrec · 2025-10-09T13:10:43Z

.github/workflows/release_mac.yml

+          echo "Using brew to install basictex and adding it to PATH"
+          brew install --cask basictex


Release mac: use basictex now

jmarrec · 2025-10-09T13:11:04Z

.github/workflows/release_mac.yml

+    - name: Install required LaTeX packages by building the Test document
+      shell: bash
+      working-directory: ./doc/test
+      run: |
+        sudo tlmgr update --self
+        sudo tlmgr install enumitem framed multirow siunitx
+        xelatex dependencies.tex


install what's needed, and build the test document. If it works, then it's not missing a package

jmarrec · 2025-10-09T13:11:19Z

cmake/install_codesign_script.cmake

+file(GLOB _PYTHON_SOS
+  "${CMAKE_INSTALL_PREFIX}/python_lib/lib-dynload/*.so"
+  "${CMAKE_INSTALL_PREFIX}/python_lib/lib-dynload/*.dylib"
+  "${CMAKE_INSTALL_PREFIX}/python_lib/scipy/.dylibs/*.dylib"
+  "${CMAKE_INSTALL_PREFIX}/python_lib/numpy/.dylibs/*.dylib"
+)


Sign the numpy/scipy dylibs

jmarrec · 2025-10-09T13:13:21Z

I'm launching a final test release on my fork with all these changes at https://github.com/jmarrec/EnergyPlus/releases/tag/v25.2.0-pre-IOFreeze-6

mac: https://github.com/jmarrec/EnergyPlus/actions/runs/18377235258/job/52354170411

Co-authored-by: Julien Marrec <julien.marrec@gmail.com>

mitchute · 2025-10-09T18:48:45Z

This is ready. You can turn Mac doc builds back on in a separate PR. Merging.

jmarrec added 13 commits October 9, 2025 14:54

Fix NatLabRockies#11256 - Mac packaging;: sign scipy/numpy dylibs

132856e

macos-13 is going to be removed in December, replae with macos-15-int…

dedd28f

…el (EOL August 2027) https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

security import fails on macos-15-intel because cert already exists

8a5b5b8

mactext is 4GB and the CTAN mirrors are awful (I've been waiting 45mi…

3d86990

…nutes for the brew install to work), try basictex

missing poppler

59e9633

Debug

9c279aa

use texliveonfly

6c5864b

botched an if

59d2e04

Just tlmgr install the extra packages now

9d86b6b

renable the rest

2df4f31

Upload entire PDF folder for all runners

f83496c

macos-15-intel worked nicely, try arm64

a74da67

Comment out mac documentation build but use basictex on release_mac

38a1e9e

jmarrec self-assigned this Oct 9, 2025

jmarrec added Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze) Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Oct 9, 2025

jmarrec commented Oct 9, 2025

View reviewed changes

jmarrec requested a review from mitchute October 9, 2025 13:14

Apply suggestion from @jmarrec

4609686

Co-authored-by: Julien Marrec <julien.marrec@gmail.com>

mitchute approved these changes Oct 9, 2025

View reviewed changes

mitchute merged commit 196dd91 into NatLabRockies:develop Oct 9, 2025
11 checks passed

jmarrec deleted the 11256_Mac_packaging branch October 10, 2025 00:18

		echo "Using brew to install basictex and adding it to PATH"
		brew install --cask basictex

Conversation

jmarrec commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Description of the purpose of this PR

Pull Request Author

Reviewer

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmarrec commented Oct 9, 2025

Uh oh!

mitchute commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmarrec commented Oct 9, 2025 •

edited

Loading