Set MassFlowRateMaxAvail and MassFlowRateMinAvail for downstream leakage#11263
Set MassFlowRateMaxAvail and MassFlowRateMinAvail for downstream leakage#11263
MassFlowRateMaxAvail and MassFlowRateMinAvail for downstream leakage#11263Conversation
…/MinAvail is set when `airDistUnit.DownStreamLeak` is true; Add unit test.
| // set the max and min avail flow rates taking into acount the upstream leak | ||
| if (airDistUnit.UpStreamLeak) { | ||
| // set the max and min avail flow rates taking into account the upstream leak | ||
| if (airDistUnit.UpStreamLeak || airDistUnit.DownStreamLeak) { |
There was a problem hiding this comment.
Adding airDistUnit.DownStreamLeak allows MassFlowRateMaxAvail to be set, without this the following would never be true:
There was a problem hiding this comment.
The code below (580 - 604) is only looking at the upstream leakage fraction. If it's 0, as in the defect file, then the local variable MassFlowRateMaxAvail wont get set without this change and line 749 jumps to the else. So this change seems correct.
| Real64 NonAirSysOutput = 0.0; | ||
| Real64 LatOutputProvided = 0.0; | ||
| SimZoneAirLoopEquipment(*state, AirDistUnitNum, SysOutputProvided, NonAirSysOutput, LatOutputProvided, FirstHVACIteration, ZonePtr); | ||
| EXPECT_EQ(MassFlowRateMaxAvail * (1 - 0.29), state->dataLoopNodes->Node(thisAirTerminal.OutletNodeNum).MassFlowRate); |
There was a problem hiding this comment.
New test; Checks that the terminal outlet is the inlet minus leakage.
|
The TU leakage fractions are 0.05 and 0.07. The TU max flow is 0.35 m3/s (the no leakage case). So air entering the TU (or just after the TU entrance before the damper) should be 0.35 * (1 - 0.05) = 0.3325 m3/s. SPACE1-1 In Node is the node entering the zone so any downstream leakage would be happening within the TU or near the TU outlet node. 0.3325 * (1 - 0.07) = 0.3092 m3/s. So why does your figure show 0.25 m3/s? Questions: 1) where is this leakage going? 2) what is the magnitude of the leakage components (upstream and downstream output reports)? 3) What is the supply air flow rate leaving the air loop? 4) Which should equal the sum of the TU entering air flow rates? 5) What is the impact of leakage on zone air temperature if these TU dampers are at 100%. This is what I see in the eio file: |
@rraustad - Are you looking at the correct file? The defect file is setup as follows, there are no upstream leakage define in the model. |
|
@mitchute I've looked at this from all angles. This change looks correct. |




Pull request overview
Description of the purpose of this PR
Pull Request Author
Reviewer