Skip to content

Ensure Kiva Foundation boundingBox is Initialized#11255

Merged
mitchute merged 1 commit intodevelopfrom
fix-kiva-foundation-init
Oct 9, 2025
Merged

Ensure Kiva Foundation boundingBox is Initialized#11255
mitchute merged 1 commit intodevelopfrom
fix-kiva-foundation-init

Conversation

@mitchute
Copy link
Collaborator

@mitchute mitchute commented Oct 6, 2025

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label Oct 6, 2025
@mitchute mitchute requested a review from nealkruis October 6, 2025 17:12
@nealkruis
Copy link
Member

@mitchute it would be best to fix this in the upstream repository. We have other updates that we will likely pull into EnergyPlus and I want to keep the code in sync between both repositories.

@mitchute
Copy link
Collaborator Author

mitchute commented Oct 8, 2025

Upstream PR: bigladder/kiva#70

@nealkruis
Copy link
Member

@mitchute, this can merge, but we will likely update the entire copy of the kiva repository to address some other compiler warnings soon.

@mitchute
Copy link
Collaborator Author

mitchute commented Oct 9, 2025

@mitchute, this can merge, but we will likely update the entire copy of the kiva repository to address some other compiler warnings soon.

Sure, that works. Thanks!

@mitchute mitchute merged commit ced516e into develop Oct 9, 2025
11 of 12 checks passed
@mitchute mitchute deleted the fix-kiva-foundation-init branch October 9, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kiva Uninitialized Variable

4 participants