You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue with full load capacity at one speed does not match lowest capacity at next speed. When SolFlag = -2 make a quick check to see if the error is valid or not. Usually means the load is very near (a few watts or less) the low capacity at speed (e.g., PLR = 0 at speed = 2) and the warning is not valid.
Pull Request Author
Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
If any diffs are expected, author must demonstrate they are justified using plots and descriptions
If changes fix a defect, the fix should be demonstrated in plots and descriptions
If any defect files are updated to a more recent version, upload new versions here or on DevSupport
If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
If structural output changes, add to output rules file and add OutputChange label
If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
Reviewer
Perform a Code Review on GitHub
If branch is behind develop, merge develop and build locally to check for side effects of the merge
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified
Check that performance is not impacted (CI Linux results include performance check)
Run Unit Test(s) locally
Check any new function arguments for performance impacts
Verify IDF naming conventions and styles, memos and notes and defaults
If new idf included, locally check the err file and other outputs
** Warning ** Coil control failed for AirLoopHVAC:UnitarySystem:ZONE OUTPATIENT ELEC/MECHROOM B - STORY GROUND RTU SZ-VAV HIGH-EFFICIENCY
** ~~~ ** sensible part-load ratio determined to be outside the range of 0-1.
** ~~~ ** Sensible load to be met = -55.96 (watts), and the simulation continues.
** ~~~ ** Environment=RUN PERIOD 1, at Simulation time=03/12 12:30 - 12:45
Merged in develop one final time. Assuming it all passes, we'll just merge this. @rraustad I'll trust you ran the example model and verified it. The code changes look fine.
@mitchute I tested the defect file with different weather files to see if I could get this to fail in a different manner. The same problem exists where the capacity at speed = 1 @ PLR = 1 is lower than speed = 2 @ PLR = 0. I suspect this is due to the performance curves used at each speed causing a discontinuity in capacity. I have seen this problem for some time. And yes to your test question, I was trying to find the cause/fix for those SolveRoot failures. I look at SolFlag = -2 as a developer error and this is the solution for now. Also, there is really no way for a good unit test since it's performance curve specific. I did, however, think up a way to test this prior to simulation and create a table with capacity data for each speed at PLR = 0 and PLR = 1. That would at least give the user an indication of their choice in performance curves. @mjwitte do you think that would be useful for VS coils? Still thinking that through so it's not included in this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefectIncludes code to repair a defect in EnergyPlus
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
Issue with full load capacity at one speed does not match lowest capacity at next speed. When SolFlag = -2 make a quick check to see if the error is valid or not. Usually means the load is very near (a few watts or less) the low capacity at speed (e.g., PLR = 0 at speed = 2) and the warning is not valid.
Pull Request Author
Reviewer