Skip to content

Addressed Reporting Problem in LEED Renewable Energy Source Summary Table#11225

Merged
mitchute merged 4 commits intodevelopfrom
renewable_energy_source_summary_rep_issue
Sep 26, 2025
Merged

Addressed Reporting Problem in LEED Renewable Energy Source Summary Table#11225
mitchute merged 4 commits intodevelopfrom
renewable_energy_source_summary_rep_issue

Conversation

@Nigusse
Copy link
Contributor

@Nigusse Nigusse commented Sep 23, 2025

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@Nigusse Nigusse added the Defect Includes code to repair a defect in EnergyPlus label Sep 23, 2025
@Nigusse
Copy link
Contributor Author

Nigusse commented Sep 23, 2025

Tabular output before the fix:
image

Tabular output after the fix:
image

Nigusse
Nigusse commented Sep 24, 2025
View reviewed changes
Copy link
Contributor Author

@Nigusse Nigusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results of Photovoltaic and PVWatts generator types are aggregated for LEED Summary report in table L-1. Renewable Energy Source Summary.

src/EnergyPlus/ElectricPowerServiceManager.cc
if (lc->numGenerators > 0) {
for (auto const &g : lc->elecGenCntrlObj) {
if (g->generatorType == GeneratorType::PV) {
if ((g->generatorType == GeneratorType::PV) || (g->generatorType == GeneratorType::PVWatts)) {
Copy link
Contributor Author

@Nigusse Nigusse Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, results of Generator:Photovoltaic and Generator:PVWatts generator types are aggregated in the L-1. Renewable Energy Source Summary table for LEED Summary Report.

tst/EnergyPlus/unit/OutputReportTabular.unit.cc
auto &orp = *state->dataOutRptPredefined;
EXPECT_EQ("10.00", RetrievePreDefTableEntry(*state, orp.pdchLeedRenRatCap, "Photovoltaic"));
EXPECT_EQ("0.00", RetrievePreDefTableEntry(*state, orp.pdchLeedRenAnGen, "Photovoltaic"));
}
Copy link
Contributor Author

@Nigusse Nigusse Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a unit test to demonstrate the change.

@Nigusse Nigusse added this to the EnergyPlus 25.2 milestone Sep 24, 2025
mitchute
mitchute approved these changes Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick fix. Ready to go here.

@mitchute mitchute merged commit 1233e2c into develop Sep 26, 2025
11 checks passed
@mitchute mitchute deleted the renewable_energy_source_summary_rep_issue branch September 26, 2025 21:28
@mitchute mitchute mentioned this pull request Oct 1, 2025
Closed
@Nigusse
Copy link
Contributor Author

Nigusse commented Oct 2, 2025

Thanks @mitchute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchute mitchute mitchute approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.2

Development

Successfully merging this pull request may close these issues.

Rated Capacity is not reported to L-1. Renewable Energy Source Summary Table if the Generator Type PVWatts

4 participants

@Nigusse @mitchute @nrel-bot-2 @nrel-bot-2c