Skip to content

Fix 11211 Add severe error when orphan Splitter, Mixer, or ConnectorList objects are found#11221

Merged
mitchute merged 5 commits intoNatLabRockies:developfrom
bigladder:Fix-11211-No-error-for-orphan-ConnectorList-object
Oct 12, 2025
Merged

Fix 11211 Add severe error when orphan Splitter, Mixer, or ConnectorList objects are found#11221
mitchute merged 5 commits intoNatLabRockies:developfrom
bigladder:Fix-11211-No-error-for-orphan-ConnectorList-object

Conversation

@kevin-moos
Copy link
Contributor

Pull request overview

Description of the purpose of this PR

Add severe error when orphan Splitter, Mixer, or ConnectorList objects are found.
Add unit test for orphan Splitter, Mixer, ConnectorList, Branch, and BranchList.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Sep 25, 2025
@kevin-moos kevin-moos marked this pull request as ready for review September 26, 2025 01:42
@mitchute mitchute requested a review from mjwitte October 8, 2025 18:25
GetConnectorListInput(state);
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to do better getting init_state up and running. Good fix for where the engine is currently at!

@mitchute mitchute merged commit 91dcead into NatLabRockies:develop Oct 12, 2025
11 checks passed
@kevin-moos kevin-moos deleted the Fix-11211-No-error-for-orphan-ConnectorList-object branch October 22, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No error for orphan ConnectorList object

5 participants