Adding GHE borehole field design and sizing#11217
Merged
Conversation
|
|
Collaborator
Collaborator
|
Thanks, @rraustad. I've corrected the merge issues, and will push them up in the morning. |
Collaborator
|
I'm going to be working on cleaning up the docs and transitions this morning, but would appreciate a general review of the inputs and other changes. |
mjwitte
reviewed
Oct 14, 2025
Contributor
mjwitte
left a comment
There was a problem hiding this comment.
Unit tests all run.
New test file runs, although it has lots of warnings:
************* ** Warning ** Actual air mass flow rate is smaller than 25% of water-to-air heat pump coil rated air flow rate.
************* ** ~~~ ** This error occurred 283807 total times;
************* ** ~~~ ** during Warmup 213 times;
************* ** ~~~ ** during Sizing 0 times.
************* ** ~~~ ** Max=0.050685 Min=0.000035
*************
************* ** Warning ** Plant loop falling below lower temperature limit, PlantLoop="GROUND LOOP WATER LOOP"
************* ** ~~~ ** This error occurred 16354 total times;
************* ** ~~~ ** during Warmup 489 times;
************* ** ~~~ ** during Sizing 0 times.
************* ** ~~~ ** Min=-9.323420
The eio sizing output looks incomplete?
Component Sizing Information, GroundHeatExchanger:System, VERTICAL GHE 1X4 STD, Borehole Field Locations (x1 y1) (x2 y2) ..., (0 0) (10 0)
Some further comments below. I didn't try to understand the guts of this.
doc/engineering-reference/src/simulation-models-encyclopedic-reference-002/heat-exchangers.tex
Outdated
Show resolved
Hide resolved
doc/input-output-reference/src/overview/group-condenser-equipment.tex
Outdated
Show resolved
Hide resolved
doc/input-output-reference/src/overview/group-condenser-equipment.tex
Outdated
Show resolved
Hide resolved
doc/input-output-reference/src/overview/group-condenser-equipment.tex
Outdated
Show resolved
Hide resolved
doc/input-output-reference/src/overview/group-condenser-equipment.tex
Outdated
Show resolved
Hide resolved
Collaborator
|
I've addressed the comments. Merging, but likely will follow-up with some more polish here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull request overview
OK, this continues the ground heat exchanger modeling improvements. This one is about adding the ability to design and size the borehole field itself. Lots of caveats in here, and plenty of things needed for error handling, much improved documentation, more tests, double checking my flag usages, improvements to the required input configuration to make it work, etc. I'm pushing it tonight to see how GHA feels about it, and then I'll go from there tomorrow, including plenty of walkthrough.
Notable TO-DO:
SizingPeriod:WeatherFIleDaysobject, we could make the whole sizing/load operation much more flexible and robust.Pull Request Author
Reviewer