Fix 10234 Boiler:HotWater allows 0 nominal capacity#11213
Merged
mitchute merged 6 commits intoNatLabRockies:developfrom Sep 30, 2025
Merged
Conversation
Collaborator
|
@kevin-moos can you pull in develop one more time? |
Contributor
Author
|
@mitchute I pulled develop again and also fixed the text that was causing my unit test to fail |
rraustad
approved these changes
Sep 30, 2025
Collaborator
rraustad
left a comment
There was a problem hiding this comment.
Seems reasonable given the fatal warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
Modify the IDD as \minimum> 0 so that the input processor catches the input error and doesn't run a simulation with 0 nominal capacity.
Pull Request Author
Reviewer