Skip to content

Fix 10234 Boiler:HotWater allows 0 nominal capacity#11213

Merged
mitchute merged 6 commits intoNatLabRockies:developfrom
bigladder:Fix-10234-BoilerHotWater-allows-0-nominal-capacity
Sep 30, 2025
Merged

Fix 10234 Boiler:HotWater allows 0 nominal capacity#11213
mitchute merged 6 commits intoNatLabRockies:developfrom
bigladder:Fix-10234-BoilerHotWater-allows-0-nominal-capacity

Conversation

@kevin-moos
Copy link
Contributor

Pull request overview

Description of the purpose of this PR

Modify the IDD as \minimum> 0 so that the input processor catches the input error and doesn't run a simulation with 0 nominal capacity.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Sep 25, 2025
@mjwitte mjwitte added this to the EnergyPlus 25.2 IO Freeze milestone Sep 25, 2025
@mitchute
Copy link
Collaborator

@kevin-moos can you pull in develop one more time?

@kevin-moos
Copy link
Contributor Author

@mitchute I pulled develop again and also fixed the text that was causing my unit test to fail

Copy link
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable given the fatal warning.

@mitchute mitchute merged commit 0fcbc2a into NatLabRockies:develop Sep 30, 2025
11 checks passed
@kevin-moos kevin-moos deleted the Fix-10234-BoilerHotWater-allows-0-nominal-capacity branch October 1, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boiler:HotWater allows 0 Nominal Capacity yet a fatal warning is issued

6 participants