Skip to content

Fix 11205 refrigeration missing from monthly end use reports#11209

Merged
mitchute merged 5 commits intoNatLabRockies:developfrom
bigladder:Fix-11205-Refrigeration-missing-from-monthly-end-use-reports
Oct 6, 2025
Merged

Fix 11205 refrigeration missing from monthly end use reports#11209
mitchute merged 5 commits intoNatLabRockies:developfrom
bigladder:Fix-11205-Refrigeration-missing-from-monthly-end-use-reports

Conversation

@kevin-moos
Copy link
Contributor

Pull request overview

Description of the purpose of this PR

Add Refrigeration end use to EndUseEnergyConsumptionElectricityMonthly report.
Add Refrigeration end use to PeakEnergyEndUseElectricityPart2Monthly report.
Add Humidifier, HeatRecovery, WaterSystems, Refrigeration, and Cogeneration end uses to ElectricComponentsOfPeakDemandMonthly report.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@kevin-moos kevin-moos marked this pull request as ready for review September 11, 2025 18:29
@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Sep 25, 2025
@mjwitte mjwitte added this to the EnergyPlus 25.2 milestone Sep 25, 2025
@mitchute
Copy link
Collaborator

@kevin-moos can you pull in develop one more time?

@kevin-moos
Copy link
Contributor Author

@mitchute I pulled develop again, but I'm still getting regressions because of the new column I added

@mjwitte mjwitte added the OutputChange Code changes output in such a way that it cannot be merged after IO freeze label Sep 30, 2025
@mjwitte
Copy link
Contributor

mjwitte commented Sep 30, 2025

@mitchute I pulled develop again, but I'm still getting regressions because of the new column I added

@kevin-moos Since this alters and existing table output, please add a description of the change to
\src\Transition\OutputRulesFiles\OutputChanges25-1-0-to-25-2-0.md

@mitchute
Copy link
Collaborator

I ran regressions locally and it all looks consistent with the expected changes.

In addition to @mjwitte's comments above, the original issue stated the following:

The Input Output Reference for Output:Table:SummaryReports should be updated after these are fixed.

Should that also be included here?

@kevin-moos
Copy link
Contributor Author

My PR addresses this with changes to \doc\input-output-reference\src\standard-output-reports\output-table-summaryreports.tex

@tanaya-mankad
Copy link
Collaborator

Hi @mitchute, it looks to me that the markdown and tex have both been updated. I'll move this into "Waiting on Reviewer" if you agree.

@mitchute
Copy link
Collaborator

mitchute commented Oct 3, 2025

Hi @mitchute, it looks to me that the markdown and tex have both been updated. I'll move this into "Waiting on Reviewer" if you agree.

Thanks! I have updated it.

@mitchute
Copy link
Collaborator

mitchute commented Oct 6, 2025

GTG here. I've tested locally on Linux and Mac. We won't merge develop on this again. Merging.

@mitchute mitchute merged commit 05a6784 into NatLabRockies:develop Oct 6, 2025
9 of 11 checks passed
@kevin-moos kevin-moos deleted the Fix-11205-Refrigeration-missing-from-monthly-end-use-reports branch October 7, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refrigeration missing from monthly end use reports

6 participants