Skip to content

Fix defect 11206 blank line csv import issue#11208

Merged
mitchute merged 3 commits intoNatLabRockies:developfrom
bigladder:Fix-11206-Blank-line-CSV-import-issue
Oct 9, 2025
Merged

Fix defect 11206 blank line csv import issue#11208
mitchute merged 3 commits intoNatLabRockies:developfrom
bigladder:Fix-11206-Blank-line-CSV-import-issue

Conversation

@GaryMarksBigladder
Copy link
Contributor

Pull request overview

  • Fixes 11206

Allow for a blank line at the end of CSVs when importing, since external programs occasionally output an extra line at the end of their data files.

This fix only allows a blank line at the end, the assumption being that if a blank line is with in the data, then there's probably an issue that the user should address.

Pull Request Author

  • [ X] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • [ X] Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • [ X] Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@tanaya-mankad tanaya-mankad added the Defect Includes code to repair a defect in EnergyPlus label Sep 11, 2025
@mitchute mitchute marked this pull request as ready for review October 8, 2025 18:29
@mitchute mitchute self-requested a review October 8, 2025 18:30
@mitchute mitchute added the HighComplexityApproved Used for subcontractor defect complexity requests label Oct 9, 2025
Copy link
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged develop and ran tests locally. Merging.

@mitchute mitchute merged commit 3a8a040 into NatLabRockies:develop Oct 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus HighComplexityApproved Used for subcontractor defect complexity requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants