Skip to content

Cycling ratio is applied twice during cycling operation for HeatPump:PlantLoop:EIR:* objects#11203

Merged
mitchute merged 5 commits intodevelopfrom
cycling_ratio_plant_hp_fix
Sep 24, 2025
Merged

Cycling ratio is applied twice during cycling operation for HeatPump:PlantLoop:EIR:* objects#11203
mitchute merged 5 commits intodevelopfrom
cycling_ratio_plant_hp_fix

Conversation

@lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Sep 9, 2025 •
edited
Loading

Pull request overview

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added the Defect Includes code to repair a defect in EnergyPlus label Sep 9, 2025
@lymereJ
Copy link
Collaborator Author

lymereJ commented Sep 9, 2025

Results with this branch are shown in blue:

image

lymereJ
lymereJ commented Sep 9, 2025
View reviewed changes
src/EnergyPlus/PlantLoopHeatPumpEIR.cc Outdated
if (this->thermosiphonDisabled(state)) {
this->powerUsage = (this->loadSideHeatTransfer / this->referenceCOP) * eirModifierFuncPLR * eirModifierFuncTemp *
this->defrostPowerMultiplier * this->cyclingRatio;
this->defrostPowerMultiplier;
Copy link
Collaborator Author

@lymereJ lymereJ Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclingRatio is already applied when calculating the loadSideHeatTransfer:

https://github.com/NREL/EnergyPlus/blob/e5c5f38d7ce6f007763ba80bada6e17a9fba0042/src/EnergyPlus/PlantLoopHeatPumpEIR.cc#L621-L622

@lymereJ lymereJ added this to the EnergyPlus 25.2 milestone Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit ff41fcb

Regression Summary
  • EIO: 2
  • ERR: 1
  • ESO Big Diffs: 3

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on macos-14 for commit ff41fcb

Regression Summary
  • EIO: 2
  • ESO Big Diffs: 3

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit e6b9663

Regression Summary
  • EIO: 2
  • ERR: 1
  • ESO Big Diffs: 3

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on macos-14 for commit e6b9663

Regression Summary
  • EIO: 2
  • ESO Big Diffs: 3

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 5025d02

Regression Summary
  • EIO: 2
  • ERR: 1
  • ESO Big Diffs: 3

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

⚠️ Regressions detected on macos-14 for commit 5025d02

Regression Summary
  • EIO: 2
  • ESO Big Diffs: 3

@lymereJ lymereJ marked this pull request as ready for review September 9, 2025 06:10
rraustad
rraustad approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, and is a result of using loadSideHeatTransfer in the equation instead of availableCapacity.

@Myoldmopar
Copy link
Member

Myoldmopar commented Sep 18, 2025

I'll pull develop in here which should clean up the false test failure listed there. I'll mark it as waiting on CI as well. Assuming it's happy, I'll get this merged.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

⚠️ Regressions detected on macos-14 for commit a9b23bf

Regression Summary
  • EIO: 2
  • ESO Big Diffs: 3

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit a9b23bf

Regression Summary
  • EIO: 2
  • ERR: 1
  • ESO Big Diffs: 3

@mitchute mitchute merged commit a7fe81d into develop Sep 24, 2025
8 checks passed
@mitchute mitchute deleted the cycling_ratio_plant_hp_fix branch September 24, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

@rraustad rraustad rraustad approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.2

Development

Successfully merging this pull request may close these issues.

Incorrect cycling calculation for HeatPump:PlantLoop:EIR:*objects

4 participants

@lymereJ @Myoldmopar @rraustad @mitchute