Skip to content

Fix 11188 No match on WINDOW5 data file due to extra blank lines#11195

Merged
Myoldmopar merged 4 commits intoNatLabRockies:developfrom
bigladder:Fix-11188-No-match-on-WINDOW5-data-file
Sep 18, 2025
Merged

Fix 11188 No match on WINDOW5 data file due to extra blank lines#11195
Myoldmopar merged 4 commits intoNatLabRockies:developfrom
bigladder:Fix-11188-No-match-on-WINDOW5-data-file

Conversation

@kevin-moos
Copy link
Contributor

Pull request overview

Description of the purpose of this PR

The file attached to the issue (Window5DataFile_ExtraBlankLines.dat, generated by Berkeley Lab WINDOW 7) causes an error when running EnergyPlus. The Window5 data file parser assumes line counts based on the "Window5 Data File for EnergyPlus" line, so the extra blank line causes EnergyPlus to fail to find the window name "Example B". This change will find the line that begins with "Window Name" instead of assuming a line count.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@kevin-moos kevin-moos marked this pull request as ready for review September 11, 2025 18:28
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here

goto Label1000;
}
++FileLineCount;
if (!has_prefixi(NextLine.data, "WINDOW NAME")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not a big fan of adding another use of the Objexx utilities, this is totally fine.

SearchWindow5DataFile(*state, window5DataFilePath, ConstructName, ConstructionFound, EOFonW5File, ErrorsFound);

EXPECT_EQ(ConstructName, "EXAMPLE B");
EXPECT_TRUE(ConstructionFound);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Myoldmopar
Copy link
Member

@kevin-moos I ran Clang Format locally and it complained about a line comment line, so I adjusted that. It tested happily here, and looks good, so I'm going to go ahead and get this merged. Thanks!

@Myoldmopar Myoldmopar merged commit 0468b88 into NatLabRockies:develop Sep 18, 2025
@Myoldmopar Myoldmopar deleted the Fix-11188-No-match-on-WINDOW5-data-file branch September 18, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No match on WINDOW5 data file due to extra blank lines

3 participants