Fix 11188 No match on WINDOW5 data file due to extra blank lines#11195
Merged
Myoldmopar merged 4 commits intoNatLabRockies:developfrom Sep 18, 2025
Merged
Conversation
…ch-on-WINDOW5-data-file
Myoldmopar
approved these changes
Sep 18, 2025
| goto Label1000; | ||
| } | ||
| ++FileLineCount; | ||
| if (!has_prefixi(NextLine.data, "WINDOW NAME")) { |
Member
There was a problem hiding this comment.
Although I'm not a big fan of adding another use of the Objexx utilities, this is totally fine.
| SearchWindow5DataFile(*state, window5DataFilePath, ConstructName, ConstructionFound, EOFonW5File, ErrorsFound); | ||
|
|
||
| EXPECT_EQ(ConstructName, "EXAMPLE B"); | ||
| EXPECT_TRUE(ConstructionFound); |
Member
|
@kevin-moos I ran Clang Format locally and it complained about a line comment line, so I adjusted that. It tested happily here, and looks good, so I'm going to go ahead and get this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
The file attached to the issue (Window5DataFile_ExtraBlankLines.dat, generated by Berkeley Lab WINDOW 7) causes an error when running EnergyPlus. The Window5 data file parser assumes line counts based on the "Window5 Data File for EnergyPlus" line, so the extra blank line causes EnergyPlus to fail to find the window name "Example B". This change will find the line that begins with "Window Name" instead of assuming a line count.
Pull Request Author
Reviewer