Pull request overview

• Fixes PlantEquipmentOperation incorrect upper limit minimum to zero in all cases #11171

Description of the purpose of this PR

A user noted that for temperature based plant condenser loop operation schemes that temperature controls that used temperatures below 0C for the maximum of the range resulted in a severe error. This was problematic because in very cold climates it might be necessary to have control ranges that allow for temperatures below zero. It was also in conflict with the IDD which had a clear ranger of -70C to +70C as the range of allowable temperatures. As part of the fix, the checks within the get algorithm were removed because they are made superfluous by the correct definition of the IDD which already checks limits correctly before the code even get to this get algorithm. The code that makes sure that the minimum of the range is less than the maximum of the range was left in tact. No anticipated differences in the program output since this corrects an input reading issue and should not result in any calculation differences.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs