#11054 - Part 2 - Crash with schedule with missing day types#11173

Merged

Myoldmopar merged 3 commits intodevelopfrom

Sep 4, 2025

Contributor

jmarrec commented Aug 26, 2025 •

edited

Loading

Pull request overview

Fixes Crash with schedule with missing day types #11054
Fix #11054 - Crash with schedule with missing day types #11085 had fixed it for the defect file at that time
But another defect file was supplied a month later (Crash with schedule with missing day types #11054 (comment)), which has a Schedule:Compact with missing day types AND a ScheduleTypeLimits, and will fail in setMinMaxVals

Description of the purpose of this PR

The approach taken here is to:

InitConstantScheduleData adds a DaySchedule "MissingDaySchedule-0.0" at index 0 in Sched::daySchedules.
AddWeekSchedule initializes WeekSchedule::dayScheds to this missing day type
The warning about missing day types is retained, but there will never be a null DaySchedule pointer in the WeekSchedule::dayScheds
- Caveat: Aside from that DayType Unused weirdness https://github.com/NREL/EnergyPlus/blob/acf7908bedc967ed80ec691f4441ec01702ec23c/src/EnergyPlus/ScheduleManager.hh#L75

Defect file segfaults without fix, works with fix, eplusout.err correctly references the missing day types

   ** Warning ** ProcessScheduleInput: Schedule:Compact = NUMBER OF PEOPLE
   **   ~~~   ** has missing day types in Through=12/31
   **   ~~~   ** Last "For" field=FOR: WEEKENDS
   **   ~~~   ** Missing day types= "Holiday", "SummerDesignDay", "WinterDesignDay", "CustomDay1", "CustomDay2"
   **   ~~~   ** Missing day types will have 0.0 as Schedule Values

Pull Request Author

Reviewer

jmarrec added 3 commits

August 26, 2025 12:50


          #11054 Part 2 - modify unit tests to produce crash in setMinMaxVals l…

02aad54

…ike defect file


          #11054 - Part 2 - InitConstantScheduleData adds a DaySchedule "Missin…

53ad24a

…gDaySchedule-0.0" and AddWeekSchedule initializes dayScheds to this missing day type


          Minor adjusts to other tests now that we have 1 Internal DaySchedule …

c29b51c

…in the daySchedules vector

jmarrec requested review from Myoldmopar and amirroth

August 26, 2025 11:53

jmarrec self-assigned this

jmarrec added Defect NotIDDChange labels

jmarrec commented

View reviewed changes

src/EnergyPlus/ScheduleManager.cc

Comment on lines +324 to +326

+                      auto *missingDaySchedule = AddDaySchedule(state, "MissingDaySchedule-0.0");
+                      assert(missingDaySchedule->Num == SchedNum_AlwaysOff);
+                      missingDaySchedule->isUsed = true;

Contributor Author

jmarrec Aug 26, 2025

InitConstantScheduleData: Add a missingDaySchedule at index 0 in dataSched->daySchedules

src/EnergyPlus/ScheduleManager.cc

Comment on lines +300 to +303

+                      // Fill the dayScheds with the Missing Day Schedule (Always Off)
+                      for (int iDayType = 1; iDayType < (int)DayType::Num; ++iDayType) {
+                          weekSched->dayScheds[iDayType] = s_sched->daySchedules[SchedNum_AlwaysOff];
+                      }

Contributor Author

jmarrec Aug 26, 2025

AddWeekSchedule initializes the dayScheds to that missing schedule (except the "Unused" day type...)

src/EnergyPlus/ScheduleManager.cc

Comment on lines +287 to +288

		// When InitConstantScheduleData is called, TimeStepsInHour is 0, so we ensure 24
		daySched->tsVals.assign(Constant::iHoursInDay * max(1, s_glob->TimeStepsInHour), 0.0);

Contributor Author

jmarrec Aug 26, 2025

Perhaps I should have kept resize only, but the assign is clearer and initializes.

src/EnergyPlus/ScheduleManager.cc

Comment on lines +1224 to +1225

		// When InitConstantScheduleData is called, TimeStepsInHour is 0, so we delay it here
		static_cast<DaySchedule >(s_sched->daySchedules[SchedNum_AlwaysOff])->tsVals.assign(Constant::iHoursInDay s_glob->TimeStepsInHour, 0.0);

Contributor Author

jmarrec Aug 26, 2025

In ProcessScheduleInput, I reassign the DaySchedule to the right size now that we know the TimeStepsInHour.

src/EnergyPlus/ScheduleManager.cc

Comment on lines -2382 to -2385

-                      if (daySched == nullptr) {
-                          // We already warned in ProcessScheduleInput that there were missing days: Missing day types will have 0.0 as Schedule Values
-                          return 0.0;
-                      }

Contributor Author

jmarrec Aug 26, 2025

daySched checking for nullptr is no longer needed.

tst/EnergyPlus/unit/ScheduleManager.unit.cc

Comment on lines +1749 to +1757

+                      "  Fraction,                !- Name",
+                      "  0,                       !- Lower Limit Value",
+                      "  1,                       !- Upper Limit Value",
+                      "  Continuous,              !- Numeric Type",
+                      "  percent;                 !- Unit Type",
                       "Schedule:Compact,",
                       "  WindowVentSched,         !- Name",
-                      "  Any Number,              !- Schedule Type Limits Name",
+                      "  Fraction,                !- Schedule Type Limits Name",

Contributor Author

jmarrec Aug 26, 2025

Mod the previous test to add that ScheduleTypeLimits validation which makes it crash before fix in setMinMaxVals like the new defect file does

tst/EnergyPlus/unit/ScheduleManager.unit.cc

Comment on lines +1798 to +1809

+                  Sched::DaySchedule const *const missingDaySchedule = state->dataSched->daySchedules[Sched::SchedNum_AlwaysOff];
+                  EXPECT_EQ(0, missingDaySchedule->minVal);
+                  EXPECT_EQ(0, missingDaySchedule->maxVal);
+                  EXPECT_EQ(4 * 24, missingDaySchedule->tsVals.size());
+                  for (auto v : missingDaySchedule->tsVals) {
+                      EXPECT_EQ(0.0, v);
+                  }
+                  EXPECT_EQ(0, weekSched->minVal);
+                  EXPECT_EQ(1, weekSched->maxVal);
+                  EXPECT_EQ(missingDaySchedule, weekSched->dayScheds[(int)Sched::DayType::Sunday]);

Contributor Author

jmarrec Aug 26, 2025

We check that the missingDaySchedule in question is properly all zeroes with the right size.

The weekSched min/maxVal are ok.

And the Missing day types all point to that missingDaySchedule

github-actions bot commented Aug 26, 2025

⚠️ Regressions detected on macos-14 for commit `f9de11b`

Regression Summary

EIO: 21
Table Big Diffs: 20

Collaborator

rraustad commented Aug 26, 2025

Alternate defect file Ticket 16879.idf runs successfully after fixing the coil UA issues (Sizing:Plant with 70C and 6.222C). 11054 defect file in-v25.1 runs to completion with:

** Warning ** ProcessScheduleInput: DecodeHHMMField, Invalid "until" field value is not a multiple of the minutes for each timestep: 5:05
**   ~~~   ** Other errors may result. Occurred in Day Schedule=10012_100_24_24
** Warning ** ProcessScheduleInput: Schedule:Compact = WINDOWVENTSCHED
**   ~~~   ** has missing day types in Through=12/31
**   ~~~   ** Last "For" field=FOR: MONDAY TUESDAY WEDNESDAY THURSDAY FRIDAY SATURDAY
**   ~~~   ** Missing day types= "Sunday", "Holiday", "SummerDesignDay", "WinterDesignDay", "CustomDay1", "CustomDay2"
**   ~~~   ** Missing day types will have 0.0 as Schedule Values

Collaborator

rraustad commented Aug 26, 2025

New entry in eio file for missing day schedule:

+DaySchedule - Timestep,MissingDaySchedule-0.0,,No,Values:,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00

rraustad approved these changes

View reviewed changes

Collaborator

rraustad left a comment

Defect files run correctly with associated warnings reported to err file.

Member

Myoldmopar commented Sep 4, 2025

Looks good to me, I'll do a quick check locally.

Member

Myoldmopar commented Sep 4, 2025

Happy to get this fix in. Thanks @jmarrec, and @rraustad for looking it over.

Myoldmopar merged commit 85c0f61 into develop

11 checks passed

Myoldmopar deleted the 11054_Part2 branch

September 4, 2025 00:26

mjwitte mentioned this pull request

Crash with empty err file when Schedule:Compact missing For days #11222

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect NotIDDChange