Quick fix #11157 - Incorrect StoreType for Zone Combined Outdoor Air Volume Flow Rate output variables#11169
Merged
Myoldmopar merged 1 commit intodevelopfrom Sep 18, 2025
Merged
Conversation
…Volume Flow Rate output variables
|
Myoldmopar
approved these changes
Sep 18, 2025
Member
Myoldmopar
left a comment
There was a problem hiding this comment.
Yes, for sure. I'm almost tempted to say we should be able to detect the sum/average based on the specified unit type, but whether we can or not -- we aren't doing it here. :)
Member
|
Thanks @jmarrec, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
I don't think it warrants making this an actual defect ticket and writing complicated unit tests, so I'm just fixing it quickly.
I checked SetupOutputVariables.csv (parse_output_variables.py) and didn't find other "Flow Rate" variables with StoreType::Sum instead of average
Description of the purpose of this PR
Pull Request Author
Reviewer