Skip to content

Defect 11155, fix negative formatting for EIR-F-PLR curve error message#11165

Merged
mitchute merged 17 commits intoNatLabRockies:developfrom
bigladder:Fix-11155-Negative-Formatting-For-Curves
Oct 31, 2025
Merged

Defect 11155, fix negative formatting for EIR-F-PLR curve error message#11165
mitchute merged 17 commits intoNatLabRockies:developfrom
bigladder:Fix-11155-Negative-Formatting-For-Curves

Conversation

@GaryMarksBigladder
Copy link
Contributor

@GaryMarksBigladder GaryMarksBigladder commented Aug 22, 2025

Pull request overview

Description of the purpose of this PR

Fix error message formatting when chiller EIR-F-PLR curve values are negative

Pull Request Author

Gary Marks

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@GaryMarksBigladder
Fixing and issue with negative values being truncated to zero in chil…
48be0a9 
…lers, see bug 11155
@GaryMarksBigladder
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into Fix…
d0337b1 
…-11155-Negative-Formatting-For-Curves
@GaryMarksBigladder
Fixing and issue with negative values being truncated to zero in chil…
b42337b 
…lers, see bug 11155
@GaryMarksBigladder
Simplifying the unit test
8665719
@GaryMarksBigladder
Stopped using the error callback in my unit test, created a compare_e…
1a5b13a 
…rr_stream_substream to test the error output, removed the decimal formatting from no-negative numbers so the formatter can handle it, and created an array to display PLRs with the same decimal precision and the values in the error message.
@GaryMarksBigladder
Made my try catch more specific
a80c92c
@GaryMarksBigladder
Changed unit test to use EXPECT_THROW instead of try catch
39975bb
@GaryMarksBigladder
Applying formatting
bc29203
@GaryMarksBigladder
Removing try catch to all program failure on idf formatting issues
a5dc2e4
@GaryMarksBigladder
Applying formatting
c5e3f94
@GaryMarksBigladder
Removing autogeneration introduced when applying auto formatting
4ee318c
@GaryMarksBigladder
Copy link
Contributor Author

GaryMarksBigladder commented Aug 22, 2025

Removed an old way of doing rounding where it multiplied by 100, converted to an int, and then divided by 100.
While doing that I also added variable precision to the error message so you don't end up with -0.00.
Adding the variable precision meant also changing the previously hard coded PLR line to also used variable precision, so the table would line up.

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Sep 25, 2025
@tanaya-mankad tanaya-mankad marked this pull request as ready for review October 8, 2025 21:39
@mitchute mitchute added this to the EnergyPlus 25.2 milestone Oct 22, 2025
@mitchute mitchute self-requested a review October 22, 2025 18:14
@mitchute
Copy link
Collaborator

mitchute commented Oct 24, 2025

A couple unused vars here: 55ea343

I can't push to this branch, so feel free to pull it up to current and tag me when ready.

@mitchute mitchute mentioned this pull request Oct 31, 2025
Merged
25 tasks
@mitchute
Copy link
Collaborator

mitchute commented Oct 31, 2025

We'll wait for decent CI to finish up, but I think this is ready.

@mitchute
Copy link
Collaborator

mitchute commented Oct 31, 2025

Not sure why Decent CI hasn't picked this one up yet. I think it's ready, so we'll go ahead.

@mitchute mitchute merged commit a7e507b into NatLabRockies:develop Oct 31, 2025
8 checks passed
@mitchute mitchute deleted the Fix-11155-Negative-Formatting-For-Curves branch October 31, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchute mitchute Awaiting requested review from mitchute

Assignees

@GaryMarksBigladder GaryMarksBigladder

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.2

Development

Successfully merging this pull request may close these issues.

Fix formatting when chiller EIR-F-PLR curve values are negative

5 participants

@GaryMarksBigladder @mitchute @nrel-bot-2 @nrel-bot-2c @mjwitte