Conversation
This corrects the issues noted by the author of Defect #10654
A unit test was added to verify that the two corrections to the report output have been made.
rraustad
approved these changes
Aug 11, 2025
Collaborator
rraustad
left a comment
There was a problem hiding this comment.
This looks good to me.
|
Contributor
Contributor
Author
|
@mjwitte Oh, bummer. I mean good that it's getting fixed, but unfortunate that I didn't know that this was being worked on was part of something else. Yes, please let me know what your thoughts are regarding this. If I need to drop it since it's already fixed elsewhere, I'll need to plan on something else to work on for deliverables. |
…fPlantLoopReturnTemperatureReportVar
|
|
Contributor
|
@Myoldmopar @jmarrec The windows regression failed here: https://github.com/NREL/EnergyPlus/actions/runs/17504501605/job/49725059608?pr=11146 But otherwise, CI is happy. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
In the sizing reports that are sent to the EIO, the cooling and condenser loop return temperatures were not being calculated correctly (wrong sign was used to include the delta temperature). This has been corrected and a unit test has been added. The only differences in the output should be EIO files where this is reported.
Pull Request Author
Reviewer