-
Notifications
You must be signed in to change notification settings - Fork 466
Closed
Labels
DefectIncludes code to repair a defect in EnergyPlusIncludes code to repair a defect in EnergyPlus
Description
Issue overview
DesignSpecification:OutdoorAir:SpaceList with Controller:MechanicalVentilation results in zero requested OA flow rate in v24.2. In v25.1 it causes a crash, because it's calling Schedule::getCurrentVal with a null pointer.
- The basic problem is that Controller:MechanicalVentilation is set up to copy values from the DesignSpecification:OutdoorAir object(s) into the
VentilationMechanicalstruct to do certain OA component calcs. This doesn't work for DesignSpecification:OutdoorAir:SpaceList. It needs a whole new approach to evaluate the OA requirements by callingOARequirementsData::calcOAFlowRateor similar function(s). - Perhaps the whole DSOA:SpaceList approach needs to be revisited.
- And this is another use-case not covered by testing.
- @amirroth Would it be acceptable (possible?) to initialize schedule pointers to
Sched::GetScheduleAlwaysOn(state)in the declaration? Not that it would fix the zero OA issue here . . .
Operating System (Multiple choices)
Any
Operating System Version
any
Version of EnergyPlus
25.1
Unmethours link or helpdesk ticket number
Helpdesk 16870
Defect file
EnergyPlusDevSupport/DefectFiles
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
DefectIncludes code to repair a defect in EnergyPlusIncludes code to repair a defect in EnergyPlus