Skip to content

DesignSpecification:OutdoorAir:SpaceList does not work with Controller:MechanicalVentilation #11018

@mjwitte

Description

@mjwitte

Issue overview

DesignSpecification:OutdoorAir:SpaceList with Controller:MechanicalVentilation results in zero requested OA flow rate in v24.2. In v25.1 it causes a crash, because it's calling Schedule::getCurrentVal with a null pointer.

  • The basic problem is that Controller:MechanicalVentilation is set up to copy values from the DesignSpecification:OutdoorAir object(s) into the VentilationMechanical struct to do certain OA component calcs. This doesn't work for DesignSpecification:OutdoorAir:SpaceList. It needs a whole new approach to evaluate the OA requirements by calling OARequirementsData::calcOAFlowRate or similar function(s).
  • Perhaps the whole DSOA:SpaceList approach needs to be revisited.
  • And this is another use-case not covered by testing.
  • @amirroth Would it be acceptable (possible?) to initialize schedule pointers to Sched::GetScheduleAlwaysOn(state) in the declaration? Not that it would fix the zero OA issue here . . .

Operating System (Multiple choices)

Any

Operating System Version

any

Version of EnergyPlus

25.1

Unmethours link or helpdesk ticket number

Helpdesk 16870

Defect file

EnergyPlusDevSupport/DefectFiles

Metadata

Metadata

Assignees

Labels

DefectIncludes code to repair a defect in EnergyPlus

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions