Issue overview

While reviewing the sizeSrcSideASHP() function code for another task I see incorrect capacity and flow rate calculation for source side.

The current code uses the same equation for the HeatPump:PlantLoop:EIR:Heating or HeatPump:PlantLoop:EIR:Cooling coils here and shown below:

Real64 const designSourceSideHeatTransfer = tmpCapacity * (1 + 1 / this->referenceCOP);

But the above equation is applicable for HeatPump:PlantLoop:EIR:Cooling only. I think the formulation of the equation must be dependent on the coil type as shown below:

    Real64 designSourceSideHeatTransfer = 0.0;
    if (this->EIRHPType == DataPlant::PlantEquipmentType::HeatPumpEIRHeating) {
        designSourceSideHeatTransfer = tmpCapacity * (1 - 1 / this->referenceCOP);
    } else {
        designSourceSideHeatTransfer = tmpCapacity * (1 + 1 / this->referenceCOP);
    } 

The same change is required for the water source HP as well in sizeSrcSideWSHP() function.

Details

Some additional details for this issue (if relevant):

• Platform (Operating system, version)
• Version of EnergyPlus (sha)

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)