chore: migrate to graphql API when possible#96
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 98.83% 99.37% +0.54%
==========================================
Files 22 21 -1
Lines 684 632 -52
==========================================
- Hits 676 628 -48
+ Misses 7 3 -4
Partials 1 1
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #94
This pull request migrates most of GitHub API endpoint from REST API v3 to GraphQL API v4. Benefits from this migration are:
Moreover, this pull request introduces the following changes:
Metais now included in theRepositoryobject, reducing the amount of parameters passed on validators and whitelistCaveats
GetCommentsis not migrated to GraphQL API yet, since thecursorimplementation does not accept an empty string that will be used as a starting point when fetching data.