Skip to content

feat(log): format non-verbose result in table-style format#87

Merged
Namchee merged 3 commits intomasterfrom
feat/non-verbose-table
Jun 16, 2023
Merged

feat(log): format non-verbose result in table-style format#87
Namchee merged 3 commits intomasterfrom
feat/non-verbose-table

Conversation

@Namchee
Copy link
Owner

@Namchee Namchee commented Jun 15, 2023

Overview

This pull request formats the non-verbose report to be similar to the verbose one. All whitelists and validations process are now displayed in tables.

For example:

Pull Request Validation Report

This log is generated automatically by Conventional PR

+-------------------------------------------------------------------+--------+--------+
| WHITELIST                                                         | ACTIVE | RESULT |
+-------------------------------------------------------------------+--------+--------+
| Pull request is a draft and should be ignored                     | ✅     | ❌     |
| Pull request is made by a whitelisted user and should be ignored  | ❌     | ❌     |
| Pull request is submitted by a bot and should be ignored          | ✅     | ❌     |
| Pull request is submitted by administrators and should be ignored | ❌     | ❌     |
+-------------------------------------------------------------------+--------+--------+

@codecov
Copy link

codecov bot commented Jun 15, 2023 •
edited
Loading

Codecov Report

Merging #87 (155e803) into master (d513947) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   98.74%   98.80%   +0.05%     
==========================================
  Files          22       22              
  Lines         637      664      +27     
==========================================
+ Hits          629      656      +27     
  Misses          7        7              
  Partials        1        1
Impacted Files Coverage Δ
internal/formatter/console.go 100.00% <100.00%> (ø)
internal/formatter/table.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d513947...155e803. Read the comment docs.

@Namchee
Copy link
Owner Author

Namchee commented Jun 15, 2023 •
edited
Loading

TODO:

  1. Ensure testability of the code.
  2. Use the system logger as the formatting with the default one is terrible.
  3. Header could use some work.

@Namchee Namchee merged commit 15e7836 into master Jun 16, 2023
@Namchee Namchee deleted the feat/non-verbose-table branch June 16, 2023 14:56
@Namchee Namchee mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Namchee