Fix select options existence predicate#9
Merged
delambo merged 1 commit intonytimes:masterfrom Sep 26, 2012
Merged
Conversation
- `$el[0].options` would always evaluate to `true` even if the select object didn't have any option elements. So instead we're checking if the length is truthy. - `selectedIndex` would evaluate to `true` because when there is no selected item `selectedIndex` equals `-1` So in essence, stickit would try to get the current selected option value even though there were no options. This caused an issue on Internet Explorer (tested in IE7 and IE8), where it would fail when stickit tried to access the `selectedIndex` of the select tag's options array.
delambo
added a commit
that referenced
this pull request
Sep 26, 2012
Fix select options existence predicate
Contributor
|
@hlindset Once again, you have been very detailed and helpful - thank you, kind sir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I encountered some issues with Backbone.stickit on Internet Explorer (tried it on IE7 and IE8). Stickit would always try to get the currently selected option of a select input, even if it was empty. Here's what I found:
$el[0].optionswould always evaluate totrueeven if the select object didn't have any option elements. So instead I'm checking if its length is truthy.selectedIndexwould evaluate totrue, because when there is no selected itemselectedIndexequals-1. Instead I'm checking whether or not it's equal or greater than zero.