Store bindings in each view, instead of a globally shared array#8
Merged
delambo merged 1 commit intonytimes:masterfrom Sep 25, 2012
Merged
Conversation
delambo
added a commit
that referenced
this pull request
Sep 25, 2012
Store bindings in each view, instead of a globally shared array
Contributor
|
@KidkArolis Thanks! I think this cleans up the multi-view use-case that I hacked into issue #4. |
delambo
added a commit
that referenced
this pull request
Sep 25, 2012
delambo
added a commit
that referenced
this pull request
Sep 25, 2012
Contributor
|
@KidkArolis Heads up - I just committed an additional fix for this to master (the case when multiple models are initialized by calling stickit again). |
Contributor
Author
|
Good stuff :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the _modelBindings array was shared among all views, which means when one view is destroyed, all of the bindings in all views are lost.
Should I provide tests reproducing the problem?