ignore all baked vertex color lighting feature#99
Closed
watbulb wants to merge 1 commit intoNVIDIAGameWorks:mainfrom
Closed
ignore all baked vertex color lighting feature#99watbulb wants to merge 1 commit intoNVIDIAGameWorks:mainfrom
watbulb wants to merge 1 commit intoNVIDIAGameWorks:mainfrom
Conversation
Contributor
Author
|
If you agree with the change, we can add the docs to RtxOptions.md. Just let me know. |
Collaborator
|
Yes, please update RtxOptions.md, you just need to add DXVK_DOCUMENTATION_WRITE_RTX_OPTIONS_MD=1 when you run test |
Collaborator
|
Hi @watbulb, you change has been merged internally. Should be shown on GitHub when some tests finish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change/feature allows all baked lighting to be ignored during the
processVerticesstep, with a toggle-able option in the ImGui vertex options to control the feature, and optionally serialize it into thertx.conf.This feature is immensely useful for games that use baked lighting on textures, but inconsistently. The alternative would be to manually mark all these textures to ignore their baked lighting, but in games I am currently working with, this would require manual selection of thousands of textures, which is not going to happen. I believe this feature should help other projects and games that face similar challenges.