Custom Capture Keybind Fixes#95
Conversation
|
REMIX-4005 for internal tracking |
src/util/config/config.cpp
Outdated
| } | ||
| virtKeys.push_back(vk); | ||
| bFoundValidConfig = true; | ||
| } catch (...) { |
There was a problem hiding this comment.
It's usually not a good idea to just catch all possible errors. If you know the precise error being thrown for your specific failure case, it's better to catch that one specifically.
Regardless, since this represents some user provided option that is failing to parse, you should add an error log message to this catch case.
There was a problem hiding this comment.
Ahh I see - thanks! Did a revision, does that look ok?
There was a problem hiding this comment.
Looks good! Please squash your commits and I'll see about merging it in.
There was a problem hiding this comment.
If you're having issues squashing, I generally use the method in this post:
https://stackoverflow.com/a/5189600
There was a problem hiding this comment.
If you're having issues squashing, I generally use the method in this post: https://stackoverflow.com/a/5189600
That worked! Thanks, I switched over to using Cursor to help me with the github stuff - EXACTLY what I needed, just a step in the right direction haha, should be all squashed now :)
There was a problem hiding this comment.
Looks good! I'll see about getting this integrated.
09f3f79 to
a99de42
Compare
6e58c39 to
a59a594
Compare
|
This has been merged internally, and should show up on Github once the automated pipelines push everything through |
My last commit was a huge mess, this one should be much cleaner (never using git terminal to try and mess with github again lol)
Let me know if any adjustments need to be made :)