Allow us to override the shader versions for pixel and vertex shaders individually.#68
Closed
Xenthio wants to merge 2 commits intoNVIDIAGameWorks:mainfrom
Closed
Allow us to override the shader versions for pixel and vertex shaders individually.#68Xenthio wants to merge 2 commits intoNVIDIAGameWorks:mainfrom
Xenthio wants to merge 2 commits intoNVIDIAGameWorks:mainfrom
Conversation
Collaborator
MarkEHenderson
left a comment
There was a problem hiding this comment.
Please remember to add yourself to the credits! see dxvk_imgui_about.cpp
Contributor
Author
|
Alright! hopefully thats all good :D |
Collaborator
|
Please squash your commits into a single commit (makes merging this a lot easier). There are a bunch of guides online for how to do that, this one seems decent: |
3f8b217 to
75d5e1e
Compare
Contributor
Author
Alright done! |
Collaborator
|
Just merged this to our internal repo. It should show up in Github within the next hour or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first PR to this repo, nothing seems broken in my testing!