Add option to configure the scene world space coordinate system#61
Merged
xbei-nv merged 1 commit intoNVIDIAGameWorks:mainfrom Mar 14, 2024
jdswebb:configurable-coordinate-system
Merged
Add option to configure the scene world space coordinate system#61xbei-nv merged 1 commit intoNVIDIAGameWorks:mainfrom jdswebb:configurable-coordinate-system
xbei-nv merged 1 commit intoNVIDIAGameWorks:mainfrom
jdswebb:configurable-coordinate-system
Conversation
|
Cherry picked this PR and tested locally |
Collaborator
|
@jdswebb Hi could you add yourself as contributors to |
Contributor
Author
Sure, I misunderstood initially and didn't see that you backed out the merge of this one. New PR now here: Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes NVIDIAGameWorks/rtx-remix#432.
SceneManager::calculateSceneRight()assumed a right-handed coordinate system, which meant it computed the wrong value for games using a left-handed coordinate system.This change adds an option
leftHandedCoordinateSystemwhich makes the world space coordinate system configurable. I have exposed this option on the developer GUI alongside thezUpoption.Testing
Tested in Star Wars Galaxies which uses a left-handed coordinate system. The terrain baking previously failed due to the incorrect value computed by
SceneManager::calculateSceneRight():Now works with the option enabled: