Skip to content

ci: Major refactor of release-workflows#2397

Merged
ko3n1g merged 35 commits into
mainfrom
ko3n1g/refactor/validate-only-release
May 11, 2026
Merged

ci: Major refactor of release-workflows#2397
ko3n1g merged 35 commits into
mainfrom
ko3n1g/refactor/validate-only-release

Conversation

@ko3n1g

@ko3n1g ko3n1g commented May 5, 2026

Copy link
Copy Markdown
Contributor

Why

See the design discussion in NVIDIA-NeMo/FW-CI-templates#466.

What

  • Delete .github/workflows/build-test-publish-wheel.yml.
  • Rewrite .github/workflows/release.yaml as the single caller for both push and workflow_dispatch.

Test plan

Rollout

  1. Land FW-CI-templates#466.
  2. Cut FW-CI-templates v1.0.0.
  3. Bump the SHA pin in this PR → tag.

…nly mode

See NVIDIA-NeMo/FW-CI-templates#466 for design discussion.

- Delete build-test-publish-wheel.yml.
- Rewrite release.{yml,yaml} as the single caller for both push and
  workflow_dispatch. validate-only derives from the trigger.
- One pin to FW-CI-templates governs PR rehearsal and real release.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from a team as a code owner May 5, 2026 08:55
@copy-pr-bot

copy-pr-bot Bot commented May 5, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

ko3n1g added 3 commits May 5, 2026 09:04
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…public env)

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g changed the title [ci] refactor: consolidate PR + release workflows; use validate-only ci: consolidate PR + release workflows; use validate-only May 5, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 106d861

@ko3n1g ko3n1g added the CI:docs Run doctest label May 5, 2026
ko3n1g added 2 commits May 5, 2026 13:48
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…quirements-file)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2af5490

@ko3n1g

ko3n1g commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 0bf3518

…ansformer

Why: HYBRID mode renders raw commits when no PR matches by
merge_commit_sha (helps release branches built via cherry-pick).
The transformer cleans up cp titles to show the inner PR title only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 8438fab

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test c004db7

@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test c004db7

…ry-run)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test afb850b

…sthrough

Why: SLACK_WEBHOOK now resolves at the env scope (public/main) so
the env-scoped secret value is used. No longer pass it as a
workflow_call secret.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4711c6e

ko3n1g added 2 commits May 7, 2026 09:24
Lets env-scoped SLACK_WEBHOOK reach the notify job in the called workflow.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 5a29145

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 42dde3e

ko3n1g added 2 commits May 7, 2026 20:14
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
chtruong814
chtruong814 previously approved these changes May 7, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4976fc8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:docs Run doctest CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants