[ci] refactor: consolidate PR + release workflows; use validate-only#3658
Merged
Conversation
|
|
||
| release: | ||
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@v0.93.0 | ||
| uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_release_library.yml@17906084f64b4353b596133c5e8b98c2347e4c8e |
Contributor
There was a problem hiding this comment.
nit: PR description says "Pinned to a SHA on the FW-CI-templates branch for iteration; will swap to a tagged release before merge." — flagging so this doesn't slip through. The old workflow pinned to v0.93.0; merging with a bare SHA makes future audits harder and bypasses any tag-level protection the templates repo may enforce.
Contributor
There was a problem hiding this comment.
Looks good overall — the consolidation is well-motivated and the validate-only / dry-run separation is clean.
One item to resolve before merge:
- SHA pin on FW-CI-templates (inline comment): needs to be swapped to a tagged release as noted in the PR description.
Minor observations (no action needed unless you disagree):
- The old
build-test-publish-wheel-summaryhad a deadSKIPPING_IS_ALLOWEDcheck (shell var was never set). Good that the newrelease-summarydrops it. cancel-in-progressis correctly gated topushevents only, so manualworkflow_dispatchreleases won't get cancelled mid-flight.- Container image bumped from
25.05-py3→25.11-py3— assumed intentional.
Suggested test cases
No perf tests impacted.
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Why: FW-CI-templates dropped GPG signing; SSH_KEY/SSH_PWD secrets no longer needed by the release pipeline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
…in-check always on) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
…quirements-file) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
chtruong814
approved these changes
May 6, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
See the design discussion in NVIDIA-NeMo/FW-CI-templates#466.
What
.github/workflows/build-test-publish-wheel.yml..github/workflows/release.yamlas the single caller for bothpushandworkflow_dispatch.validate-onlyderives from the trigger.One pin to FW-CI-templates governs both paths. Bumping it on a PR rehearses the exact same code path that ships at release.
Trigger / mode matrix
validate-onlydry-runtrueworkflow_dispatch dry-run=truefalsetruedry-runprefix.workflow_dispatch dry-run=falsefalsefalseTest plan
workflow_dispatch dry-run=true: https://github.com/NVIDIA-NeMo/Megatron-Bridge/actions/runs/25455468772 — dispatched 2026-05-06T19:07:22Zworkflow_dispatch dry-run=falseon the next planned RC.Rollout
v1.0.0.