chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-08)#3212
Closed
svcnvidia-nemo-ci wants to merge 1 commit into
Closed
chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-08)#3212svcnvidia-nemo-ci wants to merge 1 commit into
uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-08)#3212svcnvidia-nemo-ci wants to merge 1 commit into
Conversation
…-04-08) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
/ok to test 7288def |
Contributor
📝 WalkthroughWalkthroughThe Megatron-LM git submodule dependency was updated from commit Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: Update the pinned SHA in the .main.commit file to match the new
submodule SHA referenced for 3rdparty/Megatron-LM (change from ec458b67... to
51ea688a...), so scripts/switch_mcore.sh will not checkout the old commit;
ensure the exact new SHA string (51ea688a...) replaces the old one in
.main.commit and keep the file committed alongside the submodule update.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ea1d79c3-f6bb-4328-903f-89a2a9866e24
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| Subproject commit ec458b67a3e8aa3a6f811df12d371c94eb18f392 | |||
| Subproject commit 51ea688a5b7c98170d480185b60dc113de2d42d7 | |||
Contributor
There was a problem hiding this comment.
Sync .main.commit with this new submodule SHA to avoid checkout drift.
Line 1 updates 3rdparty/Megatron-LM to 51ea688a..., but .main.commit is still pinned to ec458b67.... Since scripts/switch_mcore.sh reads .main.commit to switch submodule state, ./scripts/switch_mcore.sh main will now move users back to the old commit. Please update .main.commit in the same PR to keep tooling consistent.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@3rdparty/Megatron-LM` at line 1, Update the pinned SHA in the .main.commit
file to match the new submodule SHA referenced for 3rdparty/Megatron-LM (change
from ec458b67... to 51ea688a...), so scripts/switch_mcore.sh will not checkout
the old commit; ensure the exact new SHA string (51ea688a...) replaces the old
one in .main.commit and keep the file committed alongside the submodule update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 PR to bump
uv.lockinr0.4.0.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit