feat: online load/save huggingface model weights for Megatron-FSDP#1910
Merged
Conversation
Contributor
|
/ok to test 20d9b52 |
b2a5ee5 to
49244f5
Compare
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
193f50c to
dfd956f
Compare
Signed-off-by: conver334 <conver334@gmail.com>
Contributor
|
/ok to test fe1934e |
Contributor
|
/ok to test dfccfd5 |
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Contributor
|
@conver334 need ci tests for changes, for this one we will need both functional and unit tests. cc/ @BoxiangW |
…eMo#3252) Signed-off-by: Raghav Hrishikeshan Mukundan <rmukundan@nvidia.com>
Signed-off-by: Parth Mannan <pmannan@nvidia.com>
Signed-off-by: Changlong <changlyu@amazon.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> Co-authored-by: Yan Bai <baiyan1996@icloud.com> Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com> Co-authored-by: yaoyu-33 <yaoyu.094@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…DIA-NeMo#3260) Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
…Mo#3249) Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…crash (NVIDIA-NeMo#3254) Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: zhangyuekai <zhangyuekai@foxmail.com> Signed-off-by: root <root@h20-2.cm.cluster> Signed-off-by: root <zhangyuekai@foxmail.com> Signed-off-by: Yuekai Zhang <zhangyuekai@foxmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
|
/ok to test 49e23d3 |
8 tasks
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Contributor
|
/ok to test ffa9649 |
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
Contributor
|
/ok to test 1f3e872 |
yaoyu-33
previously approved these changes
Apr 16, 2026
Signed-off-by: conver334 <conver334@gmail.com>
Signed-off-by: conver334 <conver334@gmail.com>
yaoyu-33
approved these changes
Apr 17, 2026
Contributor
|
/ok to test ae8295c |
Contributor
|
/ok to test 525921a |
Contributor
|
defer to next pr fix coverage |
1 task
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Supports online load/save huggingface model weights for Megatron-FSDP
API
see detailed usage in file: examples/conversion/hf_fsdp_roundtrip.py
Test
Summary by CodeRabbit
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.