Skip to content

ci: Major refactor of release-workflows#962

Merged
ko3n1g merged 33 commits into
mainfrom
ko3n1g/refactor/validate-only-release
May 22, 2026
Merged

ci: Major refactor of release-workflows#962
ko3n1g merged 33 commits into
mainfrom
ko3n1g/refactor/validate-only-release

Conversation

@ko3n1g

@ko3n1g ko3n1g commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Why

See the design discussion in NVIDIA-NeMo/FW-CI-templates#466.

What

  • Delete .github/workflows/build-test-publish-wheel.yml.
  • Rewrite .github/workflows/release.yaml as the single caller for both push and workflow_dispatch.

Test plan

Rollout

  1. Land FW-CI-templates#466.
  2. Cut FW-CI-templates v1.0.0.
  3. Bump the SHA pin in this PR → tag.

…nly mode

See NVIDIA-NeMo/FW-CI-templates#466 for design discussion.

- Delete build-test-publish-wheel.yml.
- Rewrite release.{yml,yaml} as the single caller for both push and
  workflow_dispatch. validate-only derives from the trigger.
- One pin to FW-CI-templates governs PR rehearsal and real release.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g and others added 15 commits May 5, 2026 13:54
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Why: FW-CI-templates dropped GPG signing; SSH_KEY/SSH_PWD secrets no
longer needed by the release pipeline.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…in-check always on)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…_release_finalize

Why: aligns with MBridge/Automodel/ExD/Run/MLM/RL — release.yaml's
nemo-evaluator path now lets the FW-CI wrapper handle release-time
docs publish via publish-docs: true + docs-target-path/run-on-version-tag-only,
matching the established pattern. release-launcher keeps publish-docs:
false because both packages share the same docs site under nemo/evaluator.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…quirements-file)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…ansformer

Why: HYBRID mode renders raw commits when no PR matches by
merge_commit_sha (helps release branches built via cherry-pick).
The transformer cleans up cp titles to show the inner PR title only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test a74610a

…ry-run)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test eaadbce

ko3n1g and others added 4 commits May 7, 2026 08:44
…sthrough

Why: SLACK_WEBHOOK now resolves at the env scope (public/main) so
the env-scoped secret value is used. No longer pass it as a
workflow_call secret.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Lets env-scoped SLACK_WEBHOOK reach the notify job in the called workflow.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented May 7, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 7669129

ko3n1g added 2 commits May 7, 2026 20:14
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants