Skip to content

docs: update README token badge to 150+ billion#367

Merged
johnnygreco merged 2 commits into
mainfrom
docs/readme-token-badge-150b
Mar 4, 2026
Merged

docs: update README token badge to 150+ billion#367
johnnygreco merged 2 commits into
mainfrom
docs/readme-token-badge-150b

Conversation

@johnnygreco

@johnnygreco johnnygreco commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update the README token badge from 100+ Billion to 150+ Billion
  • keep project messaging aligned with the current generated-token milestone

Test plan

  • run git diff main...HEAD and verify only the README badge string changed
  • confirm the badge renders correctly on the GitHub PR preview

Refresh the README tokens-generated badge so the project claim reflects the current 150+ billion total.
@johnnygreco johnnygreco requested a review from a team as a code owner March 4, 2026 18:04
@greptile-apps

greptile-apps Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the token milestone badge in README.md from 100+ Billion to 150+ Billion tokens generated, keeping project messaging aligned with current milestones. The change is minimal and low-risk.

  • Token badge string updated from 100+_Billion to 150+_Billion in the shields.io badge URL.
  • The PR also quietly modifies the "Learn more" section, renaming the "Quick Start Guide" link to "Getting Started" and changing its target URL from latest/quick-start/ to latest/. This change is not mentioned in the PR description or test plan and should be verified as intentional and confirmed that the old URL is no longer needed.

Confidence Score: 4/5

  • Safe to merge — documentation-only change with no code impact, but contains an undocumented secondary modification.
  • The badge update is trivial and correct. The score is slightly reduced because the PR silently changes a documentation link without mentioning it in the description or test plan, which warrants a quick confirmation before merging.
  • README.md — verify the undocumented link change from latest/quick-start/ to latest/ is intentional and that the old URL is no longer valid.

Important Files Changed

Filename Overview
README.md Two changes: token badge updated from 100+ to 150+ Billion (as described), plus an undocumented link change from "Quick Start Guide" (latest/quick-start/) to "Getting Started" (latest/)

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[README.md Badge] -->|Before| B["100+ Billion Tokens Generated"]
    A -->|After| C["150+ Billion Tokens Generated"]
    D[README.md Learn More Link] -->|Before| E["Quick Start Guide → /latest/quick-start/"]
    D -->|After| F["Getting Started → /latest/"]
Loading

Last reviewed commit: 74c55d5

eric-tramel
eric-tramel previously approved these changes Mar 4, 2026

@eric-tramel eric-tramel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread README.md
### 📚 Learn more

- **[Quick Start Guide](https://nvidia-nemo.github.io/DataDesigner/latest/quick-start/)** – Detailed walkthrough with more examples
- **[Getting Started](https://nvidia-nemo.github.io/DataDesigner/latest/)** – Install, configure, and generate your first dataset

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undocumented change in PR description

The PR description states only the token badge was updated, but this line also changes the "Quick Start Guide" link (pointing to latest/quick-start/) to "Getting Started" (pointing to latest/). While the new link may be intentional, it's worth confirming:

  1. That https://nvidia-nemo.github.io/DataDesigner/latest/quick-start/ is no longer a valid/maintained URL (to avoid broken links for anyone who has it bookmarked or referenced elsewhere).
  2. That this change was intentional and not an accidental modification — the PR description and test plan make no mention of it.
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 98

Comment:
**Undocumented change in PR description**

The PR description states only the token badge was updated, but this line also changes the "Quick Start Guide" link (pointing to `latest/quick-start/`) to "Getting Started" (pointing to `latest/`). While the new link may be intentional, it's worth confirming:

1. That `https://nvidia-nemo.github.io/DataDesigner/latest/quick-start/` is no longer a valid/maintained URL (to avoid broken links for anyone who has it bookmarked or referenced elsewhere).
2. That this change was intentional and not an accidental modification — the PR description and test plan make no mention of it.

How can I resolve this? If you propose a fix, please make it concise.

@johnnygreco johnnygreco merged commit 3fa8eb7 into main Mar 4, 2026
83 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants